bugGNU GRUB - Bugs: bug #38366, Config option: use LABEL instead...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #38366: Config option: use LABEL instead of UUID

Submitted by:  JPT <jpt>
Submitted on:  Thu 21 Feb 2013 12:08:38 PM UTC  
Votes:  1  
 
Category: ConfigurationSeverity: Major
Priority: 5 - NormalItem Group: Feature Request
Status: NonePrivacy: Public
Assigned to: NoneOriginator Name: JPT
Open/Closed: OpenRelease: 
Release: 1.98Reproducibility: None
Planned Release: None

Mon 01 Jul 2013 01:10:04 PM UTC, comment #5:

I hardly understand a word of what you are writing.
What poliy and what impl?
could you write in a more simple english?

As written I didn't do more than publish the patches that did the job for me. It's up to the project devs to decide what to do with it...

JPT <jpt>
Mon 01 Jul 2013 12:14:25 PM UTC, comment #4:

worth the work, are you serious? it's an essential Unix feature to have policy separate from implementation.

this addition has not been rejected as absolutely no grounds exist for such. it simply hasn't been decided-on finally yet by the project admins.

this is about a broader issue of having *the user be able to decide exactly and by broadest means* what to boot.

for example, both your patches don't account for what is in this sense inherently inaccordant GRUB_DISABLE_LINUX_UUID option, which now must remain due to backwards-compatibility almost indefinitely.

 <kernc>
Mon 01 Jul 2013 10:36:44 AM UTC, comment #3:

Well, I just modified my localy installed files. After that I thought it would be a good idea to share the changes.
If anybody wants to integrate it, do so. If not, I don't care.
Since I am no expert in linux scripting, my patches would need a review even if I created a patch the way you suggested.

I my opinion it would be worth the work, since it makes life a lot easier without much effort.

JPT <jpt>
Mon 01 Jul 2013 09:40:11 AM UTC, comment #2:

It's good to see someone taking another look at this :)

My only comments right now without looking too closely would be:

1. Why do work on obsolete 1.98 code? Better to use trunk or at least 2.00

2. Use:- diff -u original_file new_file > mypatch.patch
to create your patches,

3. Patch the filename.in files in the source tree not the final ones. The final files are generated from the .in files during build. (see also "diff -ur" to diff the whole tree)

I don't know much about how this all works now, the code has changed a lot since I made my patches back in 2010.

I gave up as it was rejected out of hand with no real explanation of the exact reasons.

Very demotivating after weeks of work.

I hope you have more success,

Barry Jackson <barjac>
Thu 21 Feb 2013 12:12:14 PM UTC, comment #1:

Ooops. More or less duplicate of
https://savannah.gnu.org/bugs/index.php?31647

JPT <jpt>
Thu 21 Feb 2013 12:08:38 PM UTC, original submission:

I added a config option which lets the user choose between the usage of UUID, LABEL and partition number.

Seems to work fine, but I don't know how to make option GRUB_USE_PARTIDTYPE visible from /etc/default/gru:

# Uncomment if you don't want GRUB to pass "root=UUID=xxx" parameter to Linux
GRUB_DISABLE_LINUX_UUID="true"
# JPT: use uuid, label or partition
GRUB_USE_PARTIDTYPE="label"

Please see attached diffs, too.

JPT <jpt>

 

Attached Files
file #27494:  10_linux.diff added by jpt (1kB - text/x-patch)
file #27495:  grub-mkconfig_lib.diff added by jpt (979B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by kernc (Posted a comment)
  • -unavailable- added by barjac (Posted a comment)
  • -unavailable- added by kernc
  • -unavailable- added by jpt (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 1 encouragement so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 30 Jun 2013 05:40:18 AM UTCkerncCarbon-Copy-=>Added kernc
    Thu 21 Feb 2013 12:08:38 PM UTCjptAttached File-=>Added 10_linux.diff, #27494
      Attached File-=>Added grub-mkconfig_lib.diff, #27495

    Back to the top


    Powered by Savane 3.1-cleanup