bugGNUstep - Bugs: bug #37799, NSOpenGLView -initWIthCoder does...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #37799: NSOpenGLView -initWIthCoder does not deserialize the NSPixelFormat

Submitted by:  Clint Smullen <daemonae>
Submitted on:  Fri 23 Nov 2012 07:18:29 PM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Fred Kiefer <FredKiefer>
Open/Closed: Closed

Wed 26 Dec 2012 07:23:36 PM UTC, comment #1:

I commited you patch with small changes. I was a bit reluctant to change the type of the first argument of getValues:... from long* to int*, but you are right on most systems GLint gets mapped to a 32bit integer. Still this change may cause problems on code that gets converted over from Macs and uses long instead of GLint.

Thank you very much for your patch

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Fri 23 Nov 2012 07:18:29 PM UTC, original submission:

A NSOpenGLView present in a NIB cannot be used immediately due to the missing pixel format (this technique works fine under OSX).

I have implemented a fix which has NSOpenGLPixelFormat properly declare its implementation of NSCoder and implement the necessary methods, marshaling the attribute data before it is handed to the backend via initWithAttributes.

I tested under Ubuntu 12.10 using GNUstep locally built with Clang 3.1 using an Xcode 4.5 generated XIB.

https://github.com/Daemonae/gnustep-gui/commit/c61b143b08d67c119a11bd4800ec14488f1b1c8a

Clint Smullen <daemonae>

 

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by daemonae (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 21 Jan 2014 08:10:33 AM UTCFredKieferStatusReady For Test=>Fixed
      Open/ClosedIn Test=>Closed
    Wed 26 Dec 2012 07:23:36 PM UTCFredKieferStatusNone=>Ready For Test
      Assigned toNone=>FredKiefer
      Open/ClosedOpen=>In Test
    Fri 23 Nov 2012 07:18:29 PM UTCdaemonaeAttached File-=>Added 0001-Add-and-use-NSCoder-in-NSOpenGLPixelFormat.patch, #26964

    Back to the top


    Powered by Savane 3.1-cleanup