bugjwhois - Bugs: bug #37135, logic bug in connect loop

 
 

bug #37135: logic bug in connect loop

Submitted by:  Mike Frysinger <vapier>
Submitted on:  Sat 18 Aug 2012 05:17:18 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: NIIBE Yutaka <gniibe>
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 14 Mar 2013 02:39:54 AM UTC, comment #1:

Thanks for your bug report.
Fixed in the development branch.
The original patch fixed the symptom, that's true.
But the real problem was more big. Basically, the loop logic was wrong.
It is now fixed in a different way.

NIIBE Yutaka <gniibe>
Project AdministratorIn charge of this item.
Sat 18 Aug 2012 05:17:18 AM UTC, original submission:

https://bugs.gentoo.org/show_bug.cgi?id=276751
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=542148

Alan Curry figured out the problem -- the loop in make_connect incorrectly breaks on error instead of breaking on success (and passing up the connection info)

patch attached

Mike Frysinger <vapier>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gniibe (Posted a comment)
  • -unavailable- added by vapier (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 14 Mar 2013 02:39:54 AM UTCgniibeStatusNone=>Fixed
      Assigned toNone=>gniibe
    Sat 18 Aug 2012 05:17:18 AM UTCvapierAttached File-=>Added jwhois-4.0-connect-logic.patch, #26378

    Back to the top


    Powered by Savane 3.1-cleanup