bugGNU Common Lisp - Bugs: bug #35325, make-array with initial-contents...

 
 

bug #35325: make-array with initial-contents is slow

Submitted by:  None
Submitted on:  Tue 17 Jan 2012 11:59:19 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 21 Nov 2013 02:59:55 PM UTC, comment #1:

Greetings, and thanks for your report! This should be fixced now in the master branch of the git repository, and find its way to the next official release.

Camm Maguire <camm>
Project Administrator
Tue 17 Jan 2012 11:59:19 PM UTC, original submission:

Calling make-array with a list for initial-contents is
poorly implemented. The list is traversed with elt, so
that copying the contents is order n^2. This is prohibitively
slow for large lists.

Maybe something like this: (not tested)

(when initial-contents-supplied-p
(if (listp initial-conents)
(do* ( (e initial-conents (cdr e))
(i 0 (1+ i))
(y (car initial-contents) (car e)))
( (null e) x)
(declare (fixnum i))
(setf (elt x i) y))

(do ((n (car dimensions))
(i 0 (1+ i)))
((>= i n))
(declare (fixnum n i))
(si:aset x i (elt initial-contents i))))
x)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by camm (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 21 Nov 2013 02:59:55 PM UTCcammStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup