bugGNU Common Lisp - Bugs: bug #35325, make-array with initial-contents...

 
 
Show feedback again

bug #35325: make-array with initial-contents is slow

Submitted by:  None
Submitted on:  Tue 17 Jan 2012 11:59:19 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 17 Jan 2012 11:59:19 PM UTC, original submission:

Calling make-array with a list for initial-contents is
poorly implemented. The list is traversed with elt, so
that copying the contents is order n^2. This is prohibitively
slow for large lists.

Maybe something like this: (not tested)

(when initial-contents-supplied-p
(if (listp initial-conents)
(do* ( (e initial-conents (cdr e))
(i 0 (1+ i))
(y (car initial-contents) (car e)))
( (null e) x)
(declare (fixnum i))
(setf (elt x i) y))

(do ((n (car dimensions))
(i 0 (1+ i)))
((>= i n))
(declare (fixnum n i))
(si:aset x i (elt initial-contents i))))
x)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

No Changes Have Been Made to This Item
Show feedback again

Back to the top


Powered by Savane 3.1-cleanup