bugGNUstep - Bugs: bug #34792, separators in horizontal menues...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #34792: separators in horizontal menues are drawn differently and very "ugly"

Submitted by:  julian <julian_>
Submitted on:  Wed 09 Nov 2011 11:28:04 PM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Quentin Mathé <qmathe>
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Wed 16 Nov 2011 01:31:17 PM UTC, comment #6:

thanks its better now.

julian <julian_>
Wed 16 Nov 2011 10:43:38 AM UTC, comment #5:

Should be fixed in svn now. I just committed my changes.

Gregory, could you take a look at -menuSeparatorColor, I kept a hack that returns the black color if NSWindows95InterfaceStyle is in use, but I think this should be moved in the Windows theme…

Quentin Mathé <qmathe>
Project MemberIn charge of this item.
Sun 13 Nov 2011 07:28:12 PM UTC, comment #4:

The backtrace was directly cause by a seemingly harmless change by Eric a few days ago. Instead of taking the last representation of an image he switched to using the first on. But here the case of an empty array will need to be handled :-)

Why this is only happening for you on the Silver theme is something I cannot comment on, as I am not suing this myself.

Fred Kiefer <FredKiefer>
Project Member
Sun 13 Nov 2011 06:29:21 PM UTC, comment #3:

This is, most likely, due to the menu theming changes I made a while back. You can feel free to take out the code which draws the line.

The main reason I did this is for the GNOME theme and because I thought it improved the look of the menu in general, but in retrospect the GNOME/GTK theme should use GTK menus instead of GNUstep ones.

GC

Gregory John Casamento <gcasa>
Project Administrator
Sun 13 Nov 2011 06:24:38 PM UTC, comment #2:

did you land some theme changes in trunk? i can't run any GUI gnustep application anymore as long as the theme is set to "Silver". exception backtrace suggests theme changes are responsible. attached.

(file #24365)

julian <julian_>
Thu 10 Nov 2011 10:54:13 AM UTC, comment #1:

I'm currently working on improving the menu theming (e.g. menu separator theming).
I'll commit a patch to correct the issue in the next days.

Cheers,
Quentin.

Quentin Mathé <qmathe>
Project MemberIn charge of this item.
Wed 09 Nov 2011 11:28:04 PM UTC, original submission:

for some reason menu separators are drawn as a menu-cell with a big fat line if you are using horizontal menus (mac or win95) but are just drawn as an empty cell (without big fat line) when using the NeXT vertical menus.

i don't see the reason why, and the big fat lines inside the menu cells really look very bad - using other themes doesn't seem to help there.

screenshots to illustrate attached

sorry for the bug-report about a cosmetic issue but these big fat lines are really hard to take.

julian <julian_>

 

Attached Files
file #24365:  backtrace added by julian_ (3kB - application/octet-stream)
file #24341:  horizontal.png added by julian_ (11kB - image/png)
file #24342:  vertical.png added by julian_ (11kB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rmottola (Updated the item)
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by gcasa (Posted a comment)
  • -unavailable- added by qmathe (Posted a comment)
  • -unavailable- added by julian_ (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 06 Mar 2013 09:33:03 AM UTCrmottolaStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 16 Nov 2011 10:43:38 AM UTCqmatheStatusIn Progress=>Ready For Test
    Sun 13 Nov 2011 06:24:38 PM UTCjulian_Attached File-=>Added backtrace, #24365
    Thu 10 Nov 2011 10:54:13 AM UTCqmatheCategoryNone=>Gui/AppKit
      Item GroupNone=>Bug
      StatusNone=>In Progress
      Assigned toNone=>qmathe
    Wed 09 Nov 2011 11:28:04 PM UTCjulian_Attached File-=>Added horizontal.png, #24341
      Attached File-=>Added vertical.png, #24342

    Back to the top


    Powered by Savane 3.1-cleanup