bugLiquid War 6 - Bugs: bug #34614, [PATCH] libpng-1.5 support

 
 

bug #34614: [PATCH] libpng-1.5 support

Submitted by:  None
Submitted on:  Fri 21 Oct 2011 06:14:01 PM UTC  
 
Category: InstallSeverity: 3 - Normal
Status: FixedPrivacy: Public
Assigned to: Christian Mauduit <ufoot>Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 24 Oct 2011 08:26:07 PM UTC, comment #2:

Applied patch on git repository. BTW, I also added support for libpng13/png.h as well, it happens nobody complained about that but there's no reason it would work better than with 14 or 15. Your patch does compile fine against 1.2, I didn't try with 1.5 but given its nature, and the fact you also patched configure.ac, I see no reason it wouldn't work out of the box.

Thanks for your help,

Christian.

Christian Mauduit <ufoot>
Project AdministratorIn charge of this item.
Sun 23 Oct 2011 09:26:01 PM UTC, comment #1:

Thanks for the patch, will apply it ASAP.

Christian Mauduit <ufoot>
Project AdministratorIn charge of this item.
Fri 21 Oct 2011 06:14:01 PM UTC, original submission:

In libpng-1.5 the struct members became private. People are expected to use the png_get_* functions. The applied patch replaces the struct access with function calls and adds support for libpng-1.5 in the configure.ac

I haven't tested this on a system with older libpng's, however png_get_rowbytes seems to be present even in libpng-1.2. So this should pose no problem.

-Wouter van Kesteren

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #24180:  liquidwar6-libpng-1.5.patch added by None (5kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by ufoot (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 05 Jan 2014 01:23:28 PM UTCufootOpen/ClosedOpen=>Closed
    Sun 18 Dec 2011 06:18:29 PM UTCufootStatusReady For Test=>Fixed
    Mon 24 Oct 2011 08:26:07 PM UTCufootCategoryEngine=>Install
      StatusIn Progress=>Ready For Test
    Sun 23 Oct 2011 09:26:21 PM UTCufootStatusNone=>In Progress
      Assigned toNone=>ufoot
    Fri 21 Oct 2011 06:14:01 PM UTCNoneAttached File-=>Added liquidwar6-libpng-1.5.patch, #24180

    Back to the top


    Powered by Savane 3.1-cleanup