bugGNU nano - Bugs: bug #28984, Compile errors on Cygwin 1.7.1

 
 

bug #28984: Compile errors on Cygwin 1.7.1

Submitted by:  Andy Koppe <ak2>
Submitted on:  Mon 22 Feb 2010 10:06:43 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Chris Allegretta <astyanax>
Open/Closed: ClosedRelease: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 07 Mar 2010 07:37:47 PM UTC, comment #1:

Alright this should be fixed as of revision 4484.

Chris Allegretta <astyanax>
Project AdministratorIn charge of this item.
Mon 22 Feb 2010 10:06:43 PM UTC, original submission:

Hi, I tried to compile nano configured with --enable-utf8 on Cygwin 1.7.1, and got a couple of errors. This is with ncursesw 5.7 and gcc 4.3.4, on nano trunk.

First issue:

gcc -DHAVE_CONFIG_H -I. -I../../src -I.. -DLOCALEDIR=\"/usr/local/share/locale\" -DSYSCONFDIR=\"/usr/local/etc\" -I/usr/include/ncursesw -g -O2 -MT nano.o -MD -MP -MF .deps/nano.Tpo -c -o nano.o ../../src/nano.c
../../src/nano.c: In function ‘handle_sigwinch’:
../../src/nano.c:1266: error: lvalue required as left operand of assignment
../../src/nano.c:1267: error: lvalue required as left operand of assignment

This concerns these lines:

/* We could check whether the COLS or LINES changed, and return
* otherwise. However, COLS and LINES are curses global variables,
* and in some cases curses has already updated them. But not in
* all cases. Argh. */
COLS = win.ws_col;
LINES = win.ws_row;

COLS and LINES are actually defined as macros that expand to function calls in curses.h, hence the errors. Removing them makes it compile and resizes seem to work ok, but of course I don't know what cases the comment refers to. Perhaps resizeterm() or is_term_resized() would be useful here?

Second issue:

gcc -DHAVE_CONFIG_H -I. -I../../src -I.. -DLOCALEDIR=\"/usr/local/share/locale\" -DSYSCONFDIR=\"/usr/local/etc\" -I/usr/include/ncursesw -g -O2 -MT winio.o -MD -MP -MF .deps/winio.Tpo -c -o winio.o ../../src/winio.c
../../src/winio.c: In function ‘get_mouseinput’:
../../src/winio.c:1749: warning: passing argument 1 of ‘sc_seq_or’ makes integer from pointer without a cast
../../src/winio.c:1749: error: expected ‘)’ before ‘;’ token

This is due to a stray semicolon.

Andy Koppe <ak2>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Updated the item)
  • -unavailable- added by astyanax (Posted a comment)
  • -unavailable- added by ak2 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 22 Feb 2014 08:00:47 PM UTCbensStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun 07 Mar 2010 07:37:47 PM UTCastyanaxStatusNone=>Ready For Test
      Assigned toNone=>astyanax

    Back to the top


    Powered by Savane 3.1-cleanup