bugGNU Octave - Bugs: bug #58858, [octave forge] (statistics) Expose...

 
 

bug #58858: [octave forge] (statistics) Expose unit tests in tbl_delim

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Thu 30 Jul 2020 07:12:19 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 25 Nov 2021 06:38:40 PM UTC, comment #6: 

@Nick:
Tried in Octave-6.4.0 & -7.0.0.

You can try if you have push access to OF. If it turns out you haven't, ask Kai for push access.

Yeah I have been working on the "pkg test" feature (with several other people). As it stands now it works a bit differently than I wrote in comment #1, sorry for that.  (After "pkg test" was finally implemented a lot of the details rapidly sank below other more immediate issues in my memory - happens often to me :-) )


@Nir:
Thanks for the fix & pushing, closing report.

@Rafael:
Thanks for reporting.

Philip Nienhuis <philipnienhuis>
Group Member
Thu 25 Nov 2021 01:32:14 AM UTC, comment #5: 
Nir Krakauer <nir_krakauer>
Thu 25 Nov 2021 12:49:11 AM UTC, comment #4: 

I don't believe I have access to push patches to the repository. At least I've never done so.

What version did you test with? There were a bunch of pkg bugs being worked on for a while and I thought this was one of them. maybe it did come up but a fix didn't make it through yet, or as often happens I'm maybe just misremembering

Nicholas Jankowski <nrjank>
Group Member
Wed 24 Nov 2021 10:24:49 PM UTC, comment #3: 

"pkg test" invokes __run_test_suite__.m that doesn't recurse into private subdirs (I just tried).
So yes I think Rafael's patch should be applied.

Will you do this please, Nick? then this report can be closed.

Philip Nienhuis <philipnienhuis>
Group Member
Wed 24 Nov 2021 06:55:38 PM UTC, comment #2: 

the patch mentioned in comment #1 has been closed as fixed, and we're now up to octave 6.4.0. 

perhaps someone can update this with current status and whether it this patch is still needed.

Nicholas Jankowski <nrjank>
Group Member
Sat 01 Aug 2020 03:07:09 PM UTC, comment #1: 

@Rafael:
[slightly OT]
Just FYI, the fix of bug #41215 ("pkg test feature") solved the problem for the default branch: "pkg test" tests all functions in all arch-independent directories and subdirectories of a package, including private/
Unfortunately it hasn't been applied to the stable branch that will become 6.1.0.
A related patch for extracting tests for compiled package functions (bug #41298) is still awaiting review.


Philip Nienhuis <philipnienhuis>
Group Member
Thu 30 Jul 2020 07:12:19 PM UTC, original submission:  

There are unit tests in inst/private/tbl_delim.m, which can not be exercised.  It would be more rational to move them into
inst/tblwrite.m.  This is what the patch attached to this bug report does.  It has been applied to the Debian package octave-statistics since 2012.

For more context on this issue, please see the discussion in:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=672756

Rafael Laboissière <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nir_krakauer (Posted a comment)
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-25 philipnienhuis StatusNeed Info Fixed
        Open/ClosedOpen Closed
    2021-11-24 nrjank StatusNone Need Info
    2020-07-30 rlaboiss Attached File- Added expose-tbl-delim-tests.patch, #49586

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code