bugGNU Octave - Bugs: bug #55970, Cannot copy figure to clipboard

 
 

bug #55970: Cannot copy figure to clipboard

Submitter:  None
Submitted:  Thu 21 Mar 2019 12:58:28 AM UTC
   
 
Category:  Plotting with OpenGL Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * 5.1.0
Operating System:  * Any Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sat 04 Jan 2020 04:40:12 AM UTC, comment #8: 

Verified.  Marking as Fixed and closing report.

Rik <rik5>
Group administrator
Thu 24 Oct 2019 08:44:04 PM UTC, comment #7: 

@Dmitri: Thanks, I fixed the test so that it no more depends on a specific toolkit or even on the structure of figure menus and toolbar:

http://hg.savannah.gnu.org/hgweb/octave/rev/c2f2fb1df9ed

Pantxo Diribarne <pantxo>
Group Member
Thu 24 Oct 2019 04:59:32 PM UTC, comment #6: 

THe tests are failing perhaps due to this change:

e.g.

http://buildbot.octave.org:8010/#/builders/12/builds/1230/steps/6/logs/stdio




***** testif HAVE_OPENGL, HAVE_QT; have_window_system () && any (strcmp ("qt", available_graphics_toolkits ()))
 toolkit = graphics_toolkit ("qt");
 hf = figure ("visible", "off");
 unwind_protect
   h = findall (hf);
   all_handles(1) = {"figure"};
   all_handles(2,1) = {"uitoolbar"};
   all_handles(3:5) = {"uimenu"};
   all_handles([6:7, 9]) = {"uipushtool"};
   all_handles([8, 10:13]) = {"uitoggletool"};
   all_handles(14:33) = {"uimenu"};
   assert (get (h, "type"), all_handles);
 unwind_protect_cleanup
   close (hf);
   graphics_toolkit (toolkit);
 end_unwind_protect
!!!!! test failed
ASSERT errors for:  assert (get (h, "type"),all_handles)
  Location  |  Observed  |  Expected  |  Reason
     .         O(34x1)      E(33x1)      Dimensions don't match


Dmitri.


Dmitri A. Sergatskov <dasergatskov>
Thu 24 Oct 2019 01:04:30 PM UTC, comment #5: 

I pushed the patch here:

http://hg.savannah.gnu.org/hgweb/octave/rev/d0f778462a51

Marking reasy for test.

Pantxo Diribarne <pantxo>
Group Member
Fri 27 Sep 2019 12:54:03 PM UTC, comment #4: 

Yes I forgot to add it again. The attached cset fixes the issue for me.

(file #47579)

Pantxo Diribarne <pantxo>
Group Member
Fri 27 Sep 2019 04:07:38 AM UTC, comment #3: 

I don't see why we can't make that feature work again, even if it only actually does something useful when using the Qt toolkit.

It looks like it was removed in this changeset:

http://hg.savannah.gnu.org/hgweb/octave/rev/bb4af245dff7

John W. Eaton <jwe>
Group administrator
Fri 27 Sep 2019 01:25:04 AM UTC, comment #2: 

Looking at bug  #55795, I don’t see any particular mention of this issue or concern. Is there some reason the cross compatible UI cannot have a copy function? Was this an oversight or a deliberate choice?

Nicholas Jankowski <nrjank>
Group Member
Fri 22 Mar 2019 12:17:07 PM UTC, comment #1: 

The menus were updated in # 55795 to be the same through all of the graphics toolkits, which is when the copy menu was lost.


John Donoghue <lostbard>
Group Member
Thu 21 Mar 2019 12:58:28 AM UTC, original submission:  

Octave 5.1.0 "x86_64-w64-mingw32" no longer supports copying figure to clipboard that was available in 4.4.0. So more of a regression than a bug. This feature was particularly useful sending figures via IM/email or inserting in a document. Presumably should be simple to restore given it was previously supported.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #47579:  fig_clipboard.patch added by pantxo (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by apjanke (subscribing because interested)
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by pantxo (Updated the item)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-01-04 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2019-11-05 apjanke Carbon-Copy- Added apjanke
    2019-10-24 pantxo StatusPatch Submitted Ready For Test
    2019-09-27 pantxo Attached File- Added fig_clipboard.patch, #47579
        CategoryPlotting Plotting with OpenGL
        StatusNone Patch Submitted
        Operating SystemMicrosoft Windows Any

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code