bugGNU Octave - Bugs: bug #54010, [octave forge] (signal) fails to...

 
 

bug #54010: [octave forge] (signal) fails to build with "'gripe_wrong_type_arg' was not declared in this scope"

Submitter:  Markus Mützel <mmuetzel>
Submitted:  Wed 30 May 2018 04:41:26 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  mtmiller
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 08 Mar 2019 04:24:37 PM UTC, comment #10: 

Signal version 1.4.1 fixes this. Unfortunately it doesn't look like any Forge admins are making releases these days.


To install 1.4.1


hg clone -r f050d888e7ef http://hg.code.sf.net/p/octave/signal
cd signal
make dist
octave --eval "pkg install signal-1.4.1.tar.gz"


Mike Miller <mtmiller>
Group Member
Fri 08 Mar 2019 03:50:20 PM UTC, comment #9: 

@Mike: I just noticed this bug after upgrading to Octave 5 on my production box at work. Is there currently any way to install the signal package in Octave 5?

Pantxo Diribarne <pantxo>
Group Member
Tue 14 Aug 2018 03:32:29 AM UTC, comment #8: 

I have adapted your patch to make the changes backwards compatible with previous versions of Octave

http://hg.code.sf.net/p/octave/signal/rev/3f7403f4c241

The signal package now builds and runs against Octave 3.8 through 5.0.

Mike Miller <mtmiller>
Group Member
Tue 05 Jun 2018 10:49:12 PM UTC, comment #7: 

Thanks to both of you. I will mark this as postponed and assign to myself to address later in the signal package, probably for 1.5.0. There will be at least a 1.4.1 bugfix release that intentionally will not include this change.

Mike Miller <mtmiller>
Group Member
Tue 05 Jun 2018 08:26:18 PM UTC, comment #6: 

compiled ok on stable and default octave and appears to work ok - applied to mxe:

http://hg.octave.org/mxe-octave/rev/4ec5d6df4c4a

John Donoghue <lostbard>
Group Member
Mon 04 Jun 2018 06:26:01 PM UTC, comment #5: 

Thanks, appreciate the patch!

I do have permissions but I rarely test mxe-octave myself. John, can you apply the patch in file #44242 to mxe-octave?

Mike Miller <mtmiller>
Group Member
Mon 04 Jun 2018 06:22:14 PM UTC, comment #4: 

Attached a patch that applies to the signal repository.

I don't have push rights for MXE Octave. Do you? Could you push the first patch there?

(file #44292)

Markus Mützel <mmuetzel>
Group administrator
Mon 04 Jun 2018 05:19:44 PM UTC, comment #3: 

Yes, that change looks good to me. If you turn it into a mercurial patch file with a commit message, I can apply it directly to the signal repository some time in the future.

Mike Miller <mtmiller>
Group Member
Thu 31 May 2018 10:35:11 AM UTC, comment #2: 

Adding Mike as the maintainer of the signal package to the CC-list.

Could you please check if it was ok to apply this patch on MXE Octave?

Markus Mützel <mmuetzel>
Group administrator
Wed 30 May 2018 05:46:58 PM UTC, comment #1: 

The attached patch basically re-adds the patch that was already in MXE Octave before the update to of-signal-1.4.0. I only rebased it to apply on the current sources.

(file #44242)

Markus Mützel <mmuetzel>
Group administrator
Wed 30 May 2018 04:41:26 PM UTC, original submission:  

The signal package cannot be built with Octave 5.0 because "gripes.h" was removed. The deprecated functions should be replaced by those declared in "errwarn.h".

Maybe we could come up with a patch for MXE Octave to make the build bots happy again while still maintaining backwards compatibility for versions prior to Octave 4.2.

Markus Mützel <mmuetzel>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #44292:  bug54010_of_signal_depr_fcn.patch added by mmuetzel (6KiB - application/octet-stream)
file #44242:  bug54010_of_signal_dev.patch added by mmuetzel (7KiB - application/octet-stream)

 

Carbon-Copy List
  • -email is unavailable- added by pantxo (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by mtmiller
  • -email is unavailable- added by mmuetzel (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 14 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-18 mtmiller Dependencies- bugs #55949 is dependent
    2019-03-08 mtmiller Carbon-CopyRemoved 80942 -
    2019-03-08 mtmiller Carbon-CopyRemoved mtmiller -
    2019-02-12 mtmiller Dependencies- bugs #55701 is dependent
    2018-09-26 mtmiller Dependencies- bugs #54735 is dependent
    2018-08-14 mtmiller StatusPostponed Fixed
        Open/ClosedOpen Closed
    2018-06-05 mtmiller StatusPatch Submitted Postponed
        Assigned toNone mtmiller
    2018-06-04 mtmiller Carbon-Copy- Added lostbard
    2018-06-04 mmuetzel Attached File- Added bug54010_of_signal_depr_fcn.patch, #44292
    2018-05-31 mmuetzel Carbon-Copy- Added mtmiller
    2018-05-30 mmuetzel Attached File- Added bug54010_of_signal_dev.patch, #44242
        StatusNone Patch Submitted

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code