bugGNU roff - Bugs: bug #53541, [PATCH] tmac/an-old.tmac: move or...

 
 

bug #53541: [PATCH] tmac/an-old.tmac: move or add an italic correction to the right place

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Sun 01 Apr 2018 02:53:56 PM UTC
   
 
Category:  Macro man Severity:  2 - Minor
Item Group:  Rendering/Cosmetics Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 18 May 2021 03:08:06 AM UTC, comment #1: 

I implemented my own solution for this.  The `an-empty` string was disposed of on 17 and 18 September of last year.


commit e58e32ea308ac5d344b3c79b20d7f4ab2456377b
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue May 18 09:25:21 2021 +1000

    [man]: Apply italic corrections more consistently.

    * tmac/an-old.tmac (BI, IB, IR, RI): Apply italic corrections more
      consistently.  Add lengthy comment rationalizing approach.

      (RI, BI): An italic correction is now applied after the last argument
      if it is of even parity (i.e., the 2nd, 4th, 6th, ...).

    * tmac/groff_man.7.man.in (Description/Font style macros): Note that
      italic corrections are applied.

    Fixes <https://savannah.gnu.org/bugs/index.php?53541>.

    Thanks to Bjarni Ingi Gislason for the report and a suggested patch.


G. Branden Robinson <gbranden>
Group administrator
Sun 01 Apr 2018 02:53:56 PM UTC, original submission:  


From 253f4fe3004d569def78e09d870ecfdf6c0ac2a1 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Sun, 1 Apr 2018 14:14:53 +0000
Subject: [PATCH] tmac/an-old.tmac: move or add an italic correction
 to the right place

  Each argument to be italic must have the corrections '\,' and '\/'
around it.

  Add the string "\\*[empty]" to "an-result" in the macro "IR" to be
consistent with the other macros.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 tmac/an-old.tmac | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tmac/an-old.tmac b/tmac/an-old.tmac
index 01da3167..95f3ff8f 100644
--- a/tmac/an-old.tmac
+++ b/tmac/an-old.tmac
@@ -527,7 +527,7 @@
 .      as an-result \,\f[I]\\$1\f[R]\/\\$2\\*[an-empty]\"
 .      shift 2
 .    \}
-.    if \\n[.$] .as an-result \,\f[I]\\$1\"
+.    if \\n[.$] .as an-result \,\f[I]\\$1\/\"
 \\*[an-result]
 .    ft R
 .  \}
@@ -537,13 +537,13 @@
 .  an-inputcheck \\$0 \\n[.$]
 .
 .  if \\n[.$] \{\
-.    ds an-result \&\f[I]\,\\$1\f[R]\"
+.    ds an-result \&\f[I]\,\\$1\f[R]\/\"
 .    shift
 .    while (\\n[.$] >= 2) \{\
-.      as an-result \/\\$1\f[I]\,\\$2\f[R]\"
+.      as an-result \\$1\f[I]\,\\$2\f[R]\/\\*[an-empty]\"
 .      shift 2
 .    \}
-.    if \\n[.$] .as an-result \/\\$1\"
+.    if \\n[.$] .as an-result \\$1\"
 \\*[an-result]
 .    ft R
 .  \}
@@ -553,13 +553,13 @@
 .  an-inputcheck \\$0 \\n[.$]
 .
 .  if \\n[.$] \{\
-.    ds an-result \&\f[I]\,\\$1\"
+.    ds an-result \&\f[I]\,\\$1\/\"
 .    shift
 .    while (\\n[.$] >= 2) \{\
-.      as an-result \/\f[B]\\$1\f[I]\,\\$2\\*[an-empty]\"
+.      as an-result \f[B]\\$1\f[I]\,\\$2\/\\*[an-empty]\"
 .      shift 2
 .    \}
-.    if \\n[.$] .as an-result \/\f[B]\\$1\"
+.    if \\n[.$] .as an-result \f[B]\\$1\"
 \\*[an-result]
 .    ft R
 .  \}
@@ -575,7 +575,7 @@
 .      as an-result \,\f[I]\\$1\f[B]\/\\$2\\*[an-empty]\"
 .      shift 2
 .    \}
-.    if \\n[.$] .as an-result \,\f[I]\\$1\"
+.    if \\n[.$] .as an-result \,\f[I]\\$1\/\"
 \\*[an-result]
 .    ft R
 .  \}
--
2.16.2


Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bgarrigues (Updated the item)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-22 gbranden Item GroupNone Rendering/Cosmetics
    2021-05-18 gbranden StatusNone Fixed
        Assigned toNone gbranden
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.23.0
    2018-11-26 bgarrigues Severity3 - Normal 2 - Minor

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code