bugGNU Octave - Bugs: bug #50454, fsolve does not give an error when...

 
 

bug #50454: fsolve does not give an error when user supplied jacobian has wrong size

Submitter:  A.R. Burgers <arb>
Submitted:  Sat 04 Mar 2017 10:35:14 AM UTC
   
 
Category:  Libraries Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Missed Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 09 May 2017 03:59:21 AM UTC, comment #3: 

Pushed the change to the development branch here (http://hg.savannah.gnu.org/hgweb/octave/rev/70edb5512c6e).  Closing report.

Rik <rik5>
Group administrator
Sun 30 Apr 2017 04:10:47 AM UTC, comment #2: 

I reviewed the patch and it seems worthwhile.  Would you like to be credited with the patch?  We usually check code in using the following convention.


FIRSTNAME LASTNAME <email@address>


The name is for copyright purposes, and the e-mail is just in case some issue arises later with the patch that the original author could resolve.

Otherwise I can check it in using my credentials.


Rik <rik5>
Group administrator
Mon 06 Mar 2017 08:03:40 AM UTC, comment #1: 

attached script fsolve_jac reports:


x =
   2.2575e-07
   2.2575e-07
   2.2575e-07

error: fsolve: +=: nonconformant arguments (op1 is 3x1, op2 is 3x3)


after applying attached patch fsolve_jac_02.txt


x =
   2.2575e-07
   2.2575e-07
   2.2575e-07

error: fsolve: jacobian should have size (3,3), has (3,1)


(file #39898, file #39899, file #39900, file #39901)

A.R. Burgers <arb>
Sat 04 Mar 2017 10:35:14 AM UTC, original submission:  

When the user supplied jacobian has the wrong size, cryptic error messages can ensue. Think it is best to report an ill sized jacobian directly after its calculation.

See attached patch.

A.R. Burgers <arb>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #39898:  fun_ok.m added by arb (68B - text/plain)
file #39899:  fsolve_jac.m added by arb (113B - text/plain)
file #39900:  fun_wrong.m added by arb (65B - text/plain)
file #39901:  fsolve_jac_02.txt added by arb (604B - text/plain)
file #39886:  fsolve_jac_01.txt added by arb (554B - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by arb (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-05-09 rik5 StatusPatch Reviewed Fixed
        Open/ClosedOpen Closed
    2017-04-30 rik5 StatusNone Patch Reviewed
    2017-03-06 arb Attached File- Added fun_ok.m, #39898
        Attached File- Added fsolve_jac.m, #39899
        Attached File- Added fun_wrong.m, #39900
        Attached File- Added fsolve_jac_02.txt, #39901
    2017-03-04 arb Attached File- Added fsolve_jac_01.txt, #39886

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code