bugGNU Scientific Library - Bugs: bug #45521, Erroneous use of GSL_ERROR_NULL...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45521: Erroneous use of GSL_ERROR_NULL instead of GSL_ERROR macro

Submitter:  Patrick Alken <psa>
Submitted:  Fri 10 Jul 2015 03:33:02 PM UTC
   
 
Category:  None Severity:  3 - Normal
Operating System:  Status:  Fixed
Assigned to:  None Open/Closed:  Closed
Release: 

Fri 22 Jan 2021 06:52:09 AM UTC, comment #1: 

fixed in commit 7777adc8360d469bfa7e6e22a563baa9d011b724

Patrick Alken <psa>
Group administrator
Fri 10 Jul 2015 03:33:02 PM UTC, original submission:  

from matthias =at= familie =dash= sitte =dot= org

Hi list,

in reference to my previous email I dug through the whole code base, checking
each function that the 'git grep -n -p "GSL_ERROR_NULL"' returned.  Thankfully,
only a couple of more functions turned up which use GSL_ERROR_NULL instead of
GSL_ERROR. Although this might not seem relevant at first, remember that
GSL_SUCCESS equals to 0 as does NULL returned by GSL_ERROR_NULL, so there's no
way of knowing that those functions might fail if you use a custom error handler
which doesn't automatically abort.

Anyway, patch attached. If you prefer pull requests instead, let me know.

Cheers,

  Matthias

Patrick Alken <psa>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psa (Submitted the item)
  •  

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-01-22 psa StatusNone Fixed
        Open/ClosedOpen Closed
    2015-07-10 psa Attached File- Added fix_erroneous_use_of_gsl_error_null_macro.patch, #34413

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code