GNU Health - Bugs: bug #43317, Use origin on InvoiceLine
You are not allowed to post comments on this tracker with your current authentication level.
bug #43317: Use origin on InvoiceLine
Submitter: | Cédric Krier <cedk> | ||
Submitted: | Sun 28 Sep 2014 12:56:14 PM UTC | ||
Category: | Functionality | Severity: | 1 - Wish |
Item Group: | None | Status: | Fixed |
Privacy: | Public | Assigned to: | teffalump |
Open/Closed: | Closed | Release: | 2.9.0 |
Module: | health_services | Component: | None |
Jump to the original submission
Fri 08 May 2015 12:05:00 AM UTC, comment #6: |
Chris Zimmerman <teffalump> |
Tue 05 May 2015 12:50:32 AM UTC, comment #5: Yeah, you are right. I just noticed that it is possible to change the patient on an invoiced health_services item and have that change affect the invoice. Not good. However, from what I understand, the patient field on the health_services model is the only field that can have that effect. I pushed a commit to fix that. However, I'm wondering if all the fields should be read-only after the invoice? |
Chris Zimmerman <teffalump> |
Mon 04 May 2015 11:56:21 PM UTC, comment #4: Yep, thanks for that! |
Chris Zimmerman <teffalump> |
Sat 02 May 2015 06:18:17 PM UTC, comment #3: Thank you, Chris !
|
Luis Falcon <meanmicio> |
Fri 01 May 2015 04:17:26 AM UTC, comment #2: I was looking at this report and wrote a patch that uses the origin field of InvoiceLine and moves both health_service and patient fields to Function types. The health_service and patient fields query the origin field for patient and health_service values - it is a bit awkward, but it seems to work. Thoughts? Suggestions? |
Chris Zimmerman <teffalump> |
Sun 28 Sep 2014 04:27:06 PM UTC, comment #1: Ok, I agree, Do you thinking take action? or it would be assigned to me. |
oscar alvarez <oscar_alv> |
Sun 28 Sep 2014 12:56:14 PM UTC, original submission:
Instead of adding a new field on Invoice, health_services could re-use the origin field on InvoiceLine and replace the patient field by a Function field.
|
Cédric Krier <cedk> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 11 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2015-05-08 | teffalump | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2015-05-02 | meanmicio | Status | None | In Progress | |
Assigned to | oscar_alv | teffalump | |||
2015-05-01 | teffalump | Attached File | - | Added patch.diff, #33852 | |
Release | 2.7.0 | 2.9.0 | |||
2014-10-02 | meanmicio | Assigned to | None | oscar_alv | |
2014-10-02 | cedk | Assigned to | cedk | None | |
2014-10-02 | meanmicio | Category | None | Functionality | |
2014-10-02 | meanmicio | Assigned to | None | cedk | |
Release | None | 2.7.0 |
Powered by Savane 3.13-4448.
Corresponding source code
I just added a commit to prevent write and delete functions from executing for service lines of invoiced items. Along with the previous commit to make the patient readonly, these changes should prevent any of the function fields from displaying incorrect or modified information. Unless I'm mistaken, this issue is fixed and closed. =-)