bugDenemo - Bugs: bug #41615, [smf_load.c:635]: (warning)...

 
 

bug #41615: [smf_load.c:635]: (warning) Logical conjunction always evaluates to false: EXPR < 1 && EXPR > 9

Submitter:  David Binderman <dcb314>
Submitted:  Sun 16 Feb 2014 09:19:58 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Wont Fix
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 22 Nov 2014 05:31:01 PM UTC, comment #3: 

Unless this is causing trouble we can ignore it, the code isn't executed by Denemo AFAIK

Richard Shann <rshann>
Group administrator
Tue 18 Feb 2014 03:04:20 PM UTC, comment #2: 

i've been told by Nils (who maintained libsmf for a while) that the sourceforge page is NOT where libsmf is maintained these days, look here instead: https://github.com/stump/libsmf

I checked there and the code has the same error, if relevant regarding denemo or not...

Anonymous
Tue 18 Feb 2014 11:21:40 AM UTC, comment #1: 

This code is part of the libsmf package, copied here for those who have not installed libsmf. The bug appears to be present in the current libsmf source code assuming that is:

http://libsmf.sourceforge.net/api/

so the most useful thing would be to raise the bug there. It appears to be in a section devoted to some textual information that can be included in a MIDI file, so may not be relevant to Denemo (not sure - we do use information about time signatures, but I think this section is more things like copyright notices etc, which we ignore).

Anonymous
Sun 16 Feb 2014 09:19:58 PM UTC, original submission:  


Source code is

    if (event->midi_buffer[3] < 1 && event->midi_buffer[3] > 9)
        return (0);

Maybe

    if (event->midi_buffer[3] < 1 || event->midi_buffer[3] > 9)
        return (0);

would be better code.


David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rshann (Posted a comment)
  • -email is unavailable- added by dcb314 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-11-22 rshann StatusNone Wont Fix
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code