bugGNU Octave - Bugs: bug #41569, syntax error when comma is removed...

 
 

bug #41569: syntax error when comma is removed in {1, @sin} or {"a", @sin}

Submitter:  Felipe G. Nievinski <fgnievinski>
Submitted:  Wed 12 Feb 2014 02:17:11 PM UTC
   
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 3.8.0 Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 20 Feb 2014 02:27:53 PM UTC, comment #5: 

Thanks for reviewing. The check was just adapted from other tokens.

Yes, make check works for me, added a test case to parser.tst, pushed to the stable branch:

http://hg.savannah.gnu.org/hgweb/octave/rev/e4c319ed2414

Mike Miller <mtmiller>
Group Member
Thu 20 Feb 2014 07:01:24 AM UTC, comment #4: 

Mike,

I can't say for sure that it is the correct change, but it is the kind of change I would have made:  check the context and insert a comma if the correct conditions are met for that to happen.

Do all the existing tests pass?

Please also add a test for the problem that was reported so it doesn't appear again in the future.  The test could go in the test/parser.tst file.

Thanks!

John W. Eaton <jwe>
Group administrator
Thu 20 Feb 2014 06:38:21 AM UTC, comment #3: 

Attached patch fixes this regression for me. I'm not too comfortable around the parser, so I'd appreciate a once over from someone who is. Also I worked on this on default but should be able to apply cleanly to stable.

(file #30612)

Mike Miller <mtmiller>
Group Member
Wed 12 Feb 2014 04:42:45 PM UTC, comment #2: 

This is a regression from 3.6.4 where the parser did accept the syntax without a comma.  Marking the bug as confirmed.

Rik <rik5>
Group administrator
Wed 12 Feb 2014 02:18:10 PM UTC, comment #1: 

interestingly, version 3.6.4 accepts:
{1 @sin} or {"a" @sin}
so it must be 3.8.0-specific.

Felipe G. Nievinski <fgnievinski>
Wed 12 Feb 2014 02:17:11 PM UTC, original submission:  


Felipe G. Nievinski <fgnievinski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #30612:  bug41569.diff added by mtmiller (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by fgnievinski (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-02-20 mtmiller StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2014-02-20 mtmiller Attached File- Added bug41569.diff, #30612
        StatusConfirmed Patch Submitted
    2014-02-12 rik5 Carbon-CopyRemoved 72865 -
    2014-02-12 rik5 Item GroupOther Regression
        StatusNone Confirmed

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code