bugGNUstep - Bugs: bug #39081, Build error testing for blocks...

Group
 
 

bug #39081: Build error testing for blocks runtime on Mac OS X

Submitter:  Graham Lee <leeg>
Submitted:  Mon 27 May 2013 04:25:39 PM UTC
   
 
Category:  Base/Foundation Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 06 Sep 2013 08:43:33 AM UTC, comment #2: 

I just sptted this report/patch and was about to apply it, when I found Fred already did it.  It's in svn trunk. Thanks.

Richard Frith-Macdonald <CaS>
Group Member
Sun 04 Aug 2013 09:16:29 PM UTC, comment #1: 

It looks like my patch was incorrect. the symbol is _APPLE_, two underscores on each side of the word.

Graham Lee <leeg>
Mon 27 May 2013 04:25:39 PM UTC, original submission:  

As the diff shows, -base is checking for the wrong platform compatibility macro.

--- a/Headers/GNUstepBase/GSVersionMacros.h
+++ b/Headers/GNUstepBase/GSVersionMacros.h
@@ -313,7 +313,7 @@ static inline void gs_consumed(id NS_CONSUMED GS_UNUSED_ARG o) { return; }
  */
 #if __has_feature(blocks)
 #  if  OBJC2RUNTIME
-#    if defined(APPLE)
+#    if defined(_APPLE_)
 #      include <Block.h>
 #    else
 #      include <objc/blocks_runtime.h>

Graham Lee <leeg>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by CaS (Posted a comment)
  • -email is unavailable- added by leeg (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-09-06 CaS StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-cf05.
    Corresponding source code