bugGNU Octave - Bugs: bug #37756, powerset: typo on error message...

 
 

bug #37756: powerset: typo on error message and doesn't return cell array when set is empty [with patch]

Submitter:  Carnë Draug <carandraug>
Submitted:  Thu 15 Nov 2012 11:08:24 PM UTC
   
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 28 Nov 2012 07:17:02 PM UTC, comment #1: 
Jordi Gutiérrez Hermoso <jordigh>
Group Member
Thu 15 Nov 2012 11:08:24 PM UTC, original submission:  

powerset should always returns a cell array but returns an empty matrix if the input set is empty.


octave:1> powerset([])
ans = [](0x0)


Also, the error message for checking the second argument is the word "rows" is also incorrect, and mentions "third" argument.

My patch fixes this two things, furthers the documentation (which at the moment is a single line without explanation of the rows option), adds 2 more tests (one for empty set and another for the use of the rows option) and one more input check that cell arrays can only be used with cell array of strings.

Please pull changeset 9671baab36c4 from https://bitbucket.org/carandraug/octave/

Carnë

Carnë Draug <carandraug>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jordigh (Updated the item)
  • -email is unavailable- added by carandraug (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-11-28 jordigh StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2012-11-16 jordigh StatusNone Patch Submitted

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code