bugGnash - The GNU Flash player - Bugs: bug #36002, plugin crash...

 
 

bug #36002: plugin crash (basic_string::_S_construct null not valid) on squidoo.com

Submitter:  Bastiaan Jacques <bjacques>
Submitted:  Sun 25 Mar 2012 10:10:34 PM UTC
   
 
Category:  plugin Severity:  6 - Security
Release:  master Status:  Fixed
Privacy:  Public Assigned to:  bjacques
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 26 Mar 2012 01:02:46 PM UTC, comment #2: 

It doesn't crash anymore, but it doesn't load flickr photos. Filing a different bug.
Fixed with e32d5beb.

Gabriele Giacone <gg0>
Group Member
Sun 25 Mar 2012 10:44:15 PM UTC, comment #1: 

I've committed a fix for this bug. Note that the code presently precludes non-string arguments.

Bastiaan Jacques <bjacques>
Group Member
Sun 25 Mar 2012 10:10:34 PM UTC, original submission:  

STR:
1. Visit http://www.squidoo.com/kitchen-blinds
2. (If you're using a click-to-play setting): Play the Flash movie directly under 'kitchen Window Blinds Flickr Photos'.
3. Observe Firefox segfault, or plugin-container if using a recent Firefox:
  terminate called after throwing an instance of 'std::logic_error'
  what():  basic_string::_S_construct null not valid

Downstream bug URL: https://bugzilla.redhat.com/show_bug.cgi?id=672745

Terminal output suggests std::string constructor is being fed a NULL pointer. The backtrace from the RH Bugzilla points to nsPluginInstance::processPlayerRequest(). A casual reading of that function suggests API misuse: calling NPVARIANT_TO_STRING() on an NPVariant without checking whether that NPVariant is actually a string.

Gdb appears to confirm that suspicion:

#12 0x00007f6eaf73df47 in gnash::nsPluginInstance::processPlayerRequest (this=0x7f6eb7038900) at ../../../gnash/plugin/npapi/plugin.cpp:834
834                                                          invoke->args[1].get()));
(gdb) p invoke->args[1]
$3 = (gnash::GnashNPVariant &) @0x7f6eb70b1438: {_variant = {type = NPVariantType_Null, value = {boolValue = false, intValue = 0, doubleValue = 0, stringValue = {
        UTF8Characters = 0x0, UTF8Length = 11}, objectValue = 0x0}}}


Bastiaan Jacques <bjacques>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gg0 (Posted a comment)
  • -email is unavailable- added by bjacques (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-03-26 gg0 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2012-03-25 bjacques StatusConfirmed Ready For Test

    Back to the top

    Powered by Savane 3.13-cf05.
    Corresponding source code