bugGNUstep - Bugs: bug #34780, Bogus interface styles in header

Group
 
 

bug #34780: Bogus interface styles in header

Submitter:  Richard Frith-Macdonald <CaS>
Submitted:  Wed 09 Nov 2011 06:42:44 AM UTC
   
 
Category:  Gui/AppKit Severity:  2 - Minor
Item Group:  Bug Status:  Wont Fix
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 30 Oct 2020 03:16:02 PM UTC, comment #4: 

GSWindowMakerInterfaceStyle is still there.  Open another issue to remove it.  This one is being closed since the other bogus changes were removed.

Gregory John Casamento <gcasa>
Group administrator
Sun 13 May 2012 09:29:48 PM UTC, comment #3: 

I removed the GSNativeInterfaceStyle. We should make sure we have a theme that fully replaces GSWindowMakerInterfaceStyle before we remove that too.

Fred Kiefer <FredKiefer>
Group Member
Tue 15 Nov 2011 12:31:57 AM UTC, comment #2: 

I believe that the GSWindowMakerInterfaceStyle was added via a patch by Micheal Hanni which I applied.

As for the GSNativeInterfaceStyle, this should be removed.   I believe it was an early attempt by me to provide a way for us to specify that GNUstep should use the native menu format, whatever that might be.

GC

Gregory John Casamento <gcasa>
Group administrator
Mon 14 Nov 2011 01:29:10 PM UTC, comment #1: 

If two interface styles are really the same and if they should be the same, better remove one (of course the non-standard GS*). That way the temptation to make them diverge doesn't arise.
Just my 2cents-

Riccardo Mottola <rmottola>
Group Member
Wed 09 Nov 2011 06:42:44 AM UTC, original submission:  

Looking into bug #34777 I noticed that the NSInterfaceStyle.h header now has two new, non-standard interface styles added.
I think these should be removed before someone starts trying to use them and have code that depends on them!

There's really no justification for adding new styles when we have theming, and having new styles can really only lead to compatibility and maintainability problems.

I see GSWindowMakerInterfaceStyle which appears to do nothing but adjust the position of submenus... it would surely make more sense to detect the presence of WindowMaker, but even using a single user default to turn it on/off would be better than exposing it as an API option.

Also, there's GSNativeInterfaceStyle which seems to be a synonym for NSNoInterfaceStyle

Richard Frith-Macdonald <CaS>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by gcasa (Posted a comment)
  • -email is unavailable- added by rmottola (Posted a comment)
  • -email is unavailable- added by CaS (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-10-30 gcasa StatusNone Wont Fix
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code