bugCompact Disc Input and Control Library - Bugs: bug #12363, Compilation problems with gcc4,...

 
 

bug #12363: Compilation problems with gcc4, _FORTIFY_SOURCE

Submitted by:  Ville Skyttä <scop>
Submitted on:  Fri 18 Mar 2005 10:36:23 AM UTC  
 
Category: compilationSeverity: 5 - Average
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Rocky Bernstein <rocky>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 18 Mar 2005 01:38:24 PM UTC, comment #2:

Thanks.

Regarding op->foo: As far as I know, only "read" is affected by _FORTIFY_SOURCE, the other op->foo's should be fine but changing them shouldn't hurt. The info available about _FORTIFY_SOURCE is somewhat scarce at the moment, but here's a few pointers:

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=150429
http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02055.html

Ville Skyttä <scop>
Fri 18 Mar 2005 01:01:24 PM UTC, comment #1:

The duplicate declarations of gl_default_log_hander have been removed. Patch also applied, however in lib/driver it looks like there are several other instances of

op -> foo (a,b,c) which I've turned into
(op->foo) (a,b,c)

All of this will be part of release 0.73 which should be out probably within less than a month. Since that also addresses ISO 9660 reading problems as well, when that comes out I recommend using it.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Fri 18 Mar 2005 10:36:23 AM UTC, original submission:

libcdio 0.72 compilation on Fedora Core 4 test 1, gcc4, _FORTIFY_SOURCE fails with:

cd-drive.c:134: error: static declaration of 'gl_default_cdio_log_handler' follows non-static declaration
util.h:99: error: previous declaration of 'gl_default_cdio_log_handler' was here

See also the attached patch, it fixes a couple of other compilation problems with the same configuration.

Ville Skyttä <scop>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #2747:  libcdio-macro.patch added by scop (1kB - application/octet-stream - Fix a couple of gcc4 compilation problems)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Fri 18 Mar 2005 01:05:27 PM UTCrockyOpen/ClosedOpen=>Closed
Fri 18 Mar 2005 01:01:24 PM UTCrockyStatusNone=>Fixed
  Assigned toNone=>rocky
Fri 18 Mar 2005 10:36:23 AM UTCscopAttached File-=>Added libcdio-macro.patch, #2324

Back to the top


Powered by Savane 3.1-cleanup