bugGNU nano - Bugs: bug #47610, --enable-tiny switch broken

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #47610: --enable-tiny switch broken

Submitter:  Thomas Rosenau <thomas_r>
Submitted:  Sun 03 Apr 2016 07:02:41 AM UTC
   
 
Severity:  3 - Normal Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Sat 07 May 2016 08:26:20 AM UTC, comment #2: 

Closing this, as the bug is not in a release.

Benno Schulenberg <bens>
Group administrator
Mon 04 Apr 2016 05:41:33 PM UTC, comment #1: 

The compilation tests are normally run shortly before release -- then things like this get fixed.  Apparently I broke this a couple of commits ago, in r5748.

The first hunk of your patch is okay, but the rest...  It is not just about avoiding compilation errors, you also have to look at what things do.  Your patch makes Search stop working completely in tiny.

Fixed in git.  (Later this will be fixed differently, by allowing case-sentivity and backwards searches and re-searches also in tiny.  I proposed that a long time ago, but never got around to doing it.)

Thanks for reporting.

Benno Schulenberg <bens>
Group administrator
Sun 03 Apr 2016 07:02:41 AM UTC, original submission:  

Looks like the enable-tiny switch has not been sufficiently tested in the past. I get errors when compiling.

Steps to reproduce:
-------------------
$ ./configure --enable-tiny && make


Actual result:
--------------
search.c:233:5: warning: control may reach end of non-void function [-Wreturn-type]
    } else if (func == regexp_void) {
    ^
search.c:233:7: error: expected identifier or '('
    } else if (func == regexp_void) {
      ^
search.c:238:7: error: expected identifier or '('
    } else if (func == do_replace || func == flip_replace_void) {
      ^
search.c:241:7: error: expected identifier or '('
    } else if (func == do_gotolinecolumn_void) {
      ^
search.c:247:5: error: expected identifier or '('
    return -1;
    ^
search.c:248:1: error: extraneous closing brace ('}')
}
^
search.c:430:2: warning: implicit declaration of function 'go_looking' is invalid in C99 [-Wimplicit-function-declaration]
        go_looking();
        ^
search.c:490:6: error: conflicting types for 'go_looking'
void go_looking(void)
     ^
search.c:430:2: note: previous implicit declaration is here
        go_looking();
        ^
2 warnings and 6 errors generated.


Expected result:
----------------
No errors

Thomas Rosenau <thomas_r>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #36826:  fix_enable_tiny_flag_handling.patch added by thomas_r (1KiB - text/x-diff - Quickfix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by thomas_r (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-05-07 bens Open/ClosedOpen Closed
    2016-04-04 bens StatusNone Fixed
        Assigned toNone bens
        Summaryenable-tiny switch broken --enable-tiny switch broken
    2016-04-03 thomas_r Attached File- Added fix_enable_tiny_flag_handling.patch, #36826

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code