bugGNUstep - Bugs: bug #46939, -Werror set for GSSpeechServer

Group
 
 

bug #46939: -Werror set for GSSpeechServer

Submitter:  Niels Grewe <thebeing>
Submitted:  Wed 20 Jan 2016 09:23:15 PM UTC
   
 
Category:  Gui/AppKit Severity:  2 - Minor
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  FredKiefer
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 21 Jan 2018 01:34:43 PM UTC, comment #2: 

I just did remove the line that set this flag. I think it is better to have consistent compiler parameter over the whole project and not specific ones for one tool.

Fred Kiefer <FredKiefer>
Group Member
Wed 20 Jan 2016 10:51:21 PM UTC, comment #1: 

An alternative proposal,

to just remove it for standard builds
I'm not sure there is currently a way with gnustep-make, if so i missed it in the documentation.

something like:
DEBUG_OBJCFLAGS=-Werror

so it only occurrs during make debug=yes,
I'm not sure i'm entirely on board with this (that is i see the debian bug you provide has -g), that said it also has optimization flags, which I thought debug=yes disabled.

so they may be passing -g in manually rather than using make debug=yes.

a lot of projects also will only enable it if maintainer mode has been enabled with ./configure --enable-maintainer-mode

or if the version is checked out from version control (e.g. a .git dir exists) as this is removed from the release tarball.

matt rice <ratmice>
Group Member
Wed 20 Jan 2016 09:23:15 PM UTC, original submission:  

Currently, the GSSpeechServer tool is really difficult to get to build because it sets the -Werror flag on all source files. I stumbled upon this recently when I wrote my VM build scripts, but see also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811928.
 
Philosophically speaking, I'm quite in favour of -Werror (no warnings means no petty little problems to obscure big ones), but we don't do it anywhere else (as far as I'm aware), so it might make sense to remove it?

Cheers,

Niels

Niels Grewe <thebeing>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by ratmice (Posted a comment)
  • -email is unavailable- added by thebeing (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-01-21 FredKiefer StatusNone Fixed
        Assigned toNone FredKiefer
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code