bugGNU nano - Bugs: bug #46799, the formatter leaves curses mode...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #46799: the formatter leaves curses mode unnecessarily

Submitter:  Benno Schulenberg <bens>
Submitted:  Sun 03 Jan 2016 08:49:44 PM UTC
   
 
Severity:  3 - Normal Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Thu 11 Feb 2016 05:02:20 PM UTC, comment #2: 

Changed in SVN, r5632.

The formatter no longer leaves curses mode, and if the formatting program prints any error message (gofmt then has a return value of 2), it allows the user four seconds to look at them.  (She can always press ^T again if she wants to see them again.)

Benno Schulenberg <bens>
Group administrator
Fri 29 Jan 2016 08:58:10 PM UTC, comment #1: 

Chris?  Can you comment on this?

Benno Schulenberg <bens>
Group administrator
Sun 03 Jan 2016 08:49:44 PM UTC, original submission:  

Hi Chris,

The function do_formatter() does an endwin(), but the comment at the start of the function says that the formatter is expected to run non-interactively.  If the latter is the case, the formatter will not need the screen and endwin() is unneeded.  Also, endwin() occurs right after a doupdate(), meaning that it annihilates whatever doupdate() put on the screen -- which is the message that the formatter is being started.

For both those reasons I want to get rid of endwin() in do_formatter().  Is it just a leftover from the mashup when you created the function, or... does it need to be there because the formatter for Go is somehow interactive after all?

Benno Schulenberg <bens>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-02-13 bens Open/ClosedOpen Closed
    2016-02-11 bens StatusNeed Info Fixed
        Assigned toNone bens

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code