bugGNU Wget - Bugs: bug #46537, Compilation of 1.17 fails when no...

 
 

bug #46537: Compilation of 1.17 fails when no SSL: 'using_data_security' undeclared

Submitter:  Hannu Nyman <hnyman>
Submitted:  Thu 26 Nov 2015 09:05:42 AM UTC
   
 
Category:  Build/Install Severity:  3 - Normal
Priority:  5 - Normal Status:  Fixed
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  1.17 Operating System:  GNU/Linux
Reproducibility:  Every Time Fixed Release:  trunk
Planned Release:  None Regression:  Yes
Work Required:  None Patch Included:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 26 Nov 2015 09:45:48 AM UTC, comment #2: 

Just found out that there is already discussion about this in the mailing list:
http://lists.gnu.org/archive/html/bug-wget/2015-11/msg00074.html

Hannu Nyman <hnyman>
Thu 26 Nov 2015 09:23:43 AM UTC, comment #1: 

There is apparently a second similar HAVE_SSL definition thing:
SCHEME_FTPS is declared inside a HAVE_SSL ifdef, but it is evaluated in main.o outside such wrapper, causing a second compilation error.

Lines 1845 and 1851:

http://git.savannah.gnu.org/cgit/wget.git/tree/src/main.c#n1845

Hannu Nyman <hnyman>
Thu 26 Nov 2015 09:05:42 AM UTC, original submission:  

When wget 1.17 is compiled without SSL support, the compilation fails:

ftp.c: In function 'getftp':
ftp.c:396:7: error: 'using_data_security' undeclared (first use in this function)
       using_data_security = con->st & DATA_CHANNEL_SECURITY;
       ^
ftp.c:396:7: note: each undeclared identifier is reported only once for each function it appears in

That is because on line 396 there is one statement with 'using_data_security' outside the "ifdef HAVE_SSL" wrappers.

http://git.savannah.gnu.org/cgit/wget.git/tree/src/ftp.c?id=v1.17#n396

The variable introduction is inside ifdef, which makes it unknown when no SSL support is active:
http://git.savannah.gnu.org/cgit/wget.git/tree/src/ftp.c?id=v1.17#n336

The bug is due to commit http://git.savannah.gnu.org/cgit/wget.git/commit/src/ftp.c?id=f8901af4e02d69c1d8cbedc5d344269d54a73498

Bug is present both in the released 1.17 code and the git master branch.


Ps.
release 1.17 is missing from the bug tracker's release dropdown.

Hannu Nyman <hnyman>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by darnir (Updated the item)
  • -email is unavailable- added by hnyman (Submitted the item)
  •  

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-12-03 darnir StatusNone Fixed
        Open/ClosedOpen Closed
        Releasetrunk 1.17
        Fixed ReleaseNone trunk

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code