GNU nano - Bugs: bug #46414, undoing the insertion of a file...
You are not allowed to post comments on this tracker with your current authentication level.
bug #46414: undoing the insertion of a file that doesn't end in a newline goes wrong
Submitter: | Benno Schulenberg <bens> | ||
Submitted: | Tue 10 Nov 2015 05:15:24 PM UTC | ||
Severity: | 4 - Important | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Closed |
Fri 13 Nov 2015 09:58:09 AM UTC, comment #5: |
Benno Schulenberg <bens> |
Wed 11 Nov 2015 02:30:10 PM UTC, comment #4: The previous patch leaves an unfinished undo item in the list when the reading of the file or the execution of the command fails, which would lead to a segfault later on when trying to undo this unfinished item.
|
Benno Schulenberg <bens> |
Tue 10 Nov 2015 09:46:32 PM UTC, comment #3: First attempt at a patch. Works for me, but probably could use some refinements. |
Benno Schulenberg <bens> |
Tue 10 Nov 2015 05:27:50 PM UTC, comment #2: Bug has been present since at least nano-2.2.5. |
Benno Schulenberg <bens> |
Tue 10 Nov 2015 05:18:48 PM UTC, comment #1: Oh, and trying to redo the insertion then segfaults. |
Benno Schulenberg <bens> |
Tue 10 Nov 2015 05:15:24 PM UTC, original submission:
When NONEWLINES is set, and having read in a file that does not end in a newline, then trying to undo it leaves the last line in place.
|
Benno Schulenberg <bens> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2015-12-07 | bens | Open/Closed | Open | Closed | |
2015-11-13 | bens | Status | Ready For Test | Fixed | |
2015-11-11 | bens | Attached File | - | Added undoing-an-insertion-right.patch, #35434 | |
2015-11-10 | bens | Attached File | - | Added properly-undo-insert.patch, #35432 | |
Status | None | Ready For Test | |||
Summary | reading in a file that doesn\'t end in a newline isn\'t properly undone | undoing the insertion of a file that doesn't end in a newline goes wrong | |||
2015-11-10 | bens | Severity | 3 - Normal | 4 - Important |
Powered by Savane 3.13-758e.
Corresponding source code
Fixed in SVN, r5404.