bugPSPP - Bugs: bug #45805, Text/Spreadsheet import assistant...

 
 

bug #45805: Text/Spreadsheet import assistant crashes after close

Submitter:  John Darrington <jmd>
Submitted:  Fri 21 Aug 2015 08:08:27 AM UTC
   
 
Category:  Graphical User Interface Severity:  5 - Average
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  None
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 26 Dec 2015 10:53:45 AM UTC, comment #5: 

I have committed a major rewrite of the text importer gui.  

I think this problem has been fixed.

John Darrington <jmd>
Group administrator
Sat 29 Aug 2015 12:52:00 PM UTC, comment #4: 

I have pushed the change mentioned in my last comment.

This is of course far from a proper fix, but it seems to me that the benefits gained by not crashing outweigh the cost of leaking a few bytes of memory.

John Darrington <jmd>
Group administrator
Tue 25 Aug 2015 04:15:14 PM UTC, comment #3: 

Thanks for the info Harry.

I am looking at this problem, but a proper fix will not be quick.

However, perhaps you can try this kludge:

in the file src/ui/gui/text-data-import-dialog.c lines 142-145:


  destroy_assistant (ia);
  destroy_file (ia);
  free (ia);


Comment them out.


This is my no means the correct fix and it will cause a memory leak, however it might work-around the problem short term.

Perhaps you can try that and see if it works.

John Darrington <jmd>
Group administrator
Tue 25 Aug 2015 12:45:48 PM UTC, comment #2: 

A second user reported this and I get it too. 

The issue seems to be introduced with the GTK3 version.

I guess it will effect a lot of users.

The only work around I can offer is:
- Download the 2015-06-21 version and install these in  a separate directory for instance PSPPo. Rename the shortcut on your desktop to PSPPo (or what you want)
- Reinstall the PSPP version you used.
- import the csv file in this old PSPP version, save them as a .sav file and load these in the patched version for further processing.

Harry Thijssen <unknown_one>
Fri 21 Aug 2015 08:13:50 AM UTC, comment #1: 

This seems to happen only on windows.  I borrowed a windows machine, and thanks to Harry's .Debug package managed to reproduce this problem and get the attached stack trace.

This seems to suggest that the (struct import_assistant) is getting
accessed in a callback after it has been freed.




(file #34686)

John Darrington <jmd>
Group administrator
Fri 21 Aug 2015 08:08:27 AM UTC, original submission:  

Julie McCredden reports:

I have converted my input file from and excel .csv file to opensource (.ods)

When I use the import data function it will import this file and I can see the data is there as it should be

but then PSPP says it has stopped working and has to close. Then it dies.

The same happens for the standard .csv file.

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #34686:  stack added by jmd (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by unknown_one (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-12-26 jmd StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2015-08-21 jmd Attached File- Added stack, #34686

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code