bugGNUstep - Bugs: bug #44933, Cairo backend: NSGraphicsContext's...

Group
 
 

bug #44933: Cairo backend: NSGraphicsContext's imageInterpolation setting is ignored

Submitter:  Josh Freeman <tedge>
Submitted:  Mon 27 Apr 2015 04:32:32 AM UTC
   
 
Category:  Backend Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  FredKiefer
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 22 May 2015 09:29:33 PM UTC, comment #1: 

Thank you for another great patch. I just submitted it to SVN.

Fred Kiefer <FredKiefer>
Group Member
Mon 27 Apr 2015 04:32:32 AM UTC, original submission:  

   Setup: VirtualBox 4.3 + Ubuntu 14.04 guest, Clang, GNUstep from current SVN trunk

   Scaled images drawn with the Cairo backend are always interpolated (blurred), even when interpolation is disabled in the current NSGraphicsContext (imageInterpolation set to NSImageInterpolationNone).

   This is because the CairoGState class hard-codes all calls to cairo_pattern_set_filter() (Cairo function for setting interpolation type) with the interpolation value, CAIRO_FILTER_BILINEAR.

   The attached patch updates CairoGState's cairo_pattern_set_filter() calls to use an appropriate value based on the graphicsContext's imageInterpolation setting. Test program is also attached.

Josh Freeman <tedge>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #33800:  TestImageInterpolation.m added by tedge (7KiB - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by tedge (Submitted the item)
  • -email is unavailable- added by tedge (This might be of interest to you, since you're the developer of an imaging app (PRICE))
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-11-18 FredKiefer StatusReady For Test Fixed
        Open/ClosedIn Test Closed
    2015-05-22 FredKiefer StatusNone Ready For Test
        Assigned toNone FredKiefer
        Open/ClosedOpen In Test
    2015-04-27 tedge Attached File- Added CairoGState_ImageInterpolation.patch, #33799
        Attached File- Added TestImageInterpolation.m, #33800
        Carbon-Copy- Added rmottola

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code