bugGNU roff - Bugs: bug #44289, [PATCH] [nroff] want -E option

 
 

bug #44289: [PATCH] [nroff] want -E option

Submitter:  Osamu Sayama <sayama>
Submitted:  Wed 18 Feb 2015 08:12:49 AM UTC
   
 
Category:  Core Severity:  1 - Wish
Item Group:  Feature change Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 21 Oct 2020 07:09:29 AM UTC, comment #3: 

Rudely poached away from Ingo.  Sorry, Ingo.


commit f1af5cdaf19c4c8f28970daa17e867a9864bf639
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue Oct 20 22:01:40 2020 +1100

    [nroff] Recognize -E and pass it to troff.

    * src/roff/nroff/nroff.sh: Recognize -E option and pass it through to
      troff.  Document it in usage message.
    * src/roff/nroff/nroff.1.man: Document new -E option.

    Tested with "printf '\\' | nroff -E", the shortest way to provoke a
    troff _error_ from the _content_ of input that I know.  Anyone for golf?

    Based on a patch by Ingo Schwarze.

    Fixes <https://savannah.gnu.org/bugs/index.php?44289>.


G. Branden Robinson <gbranden>
Group administrator
Wed 21 Oct 2020 12:40:03 AM UTC, comment #2: 

comment #1:

> I cannot see any good reason why nroff(1) should pass through -w and -W but not -E.


Agreed.  And your proposed patch is quite simple, changing only one character of executable code.  Seems very low-risk to add before the release.

(However, unless I am misreading, in the man page the patch adds -E to the Description section but not the Synopsis.)

Dave <barx>
Group Member
Tue 13 Oct 2020 08:38:46 PM UTC, comment #1: 

I agree with the intention.
I cannot see any good reason why nroff(1) should pass through -w and -W but not -E.

However, the patch #33113 is wrong and must not be committed.  It discards all standard error output, not just error messages.

Writing a better patch is trivial, see 44289_schwarze.patch.

(file #49974)

Ingo Schwarze <schwarze>
Group Member
Wed 18 Feb 2015 08:12:49 AM UTC, original submission:  

groff has -E option to disable troff error messages.
It would be great if nroff script also has this option.
I tried attached patch (nroff_disable_warn.patch).

Osamu Sayama <sayama>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49974:  44289_schwarze.patch added by schwarze (2KiB - text/x-patch)
file #33113:  nroff_disable_warn.patch added by sayama (913B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by barx (Updated the item)
  • -email is unavailable- added by schwarze (Updated the item)
  • -email is unavailable- added by sayama (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 14 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-11 gbranden CategoryDriver - others/general Core
        Summary[PATCH] nroff script -E option [PATCH] [nroff] want -E option
    2020-10-21 gbranden StatusIn Progress Fixed
        Assigned toschwarze gbranden
        Open/ClosedOpen Closed
    2020-10-13 schwarze Attached File- Added 44289_schwarze.patch, #49974
        CategoryNone Driver - others/general
        StatusNone In Progress
        Assigned toNone schwarze
        Planned ReleaseNone 1.23.0
    2020-10-13 barx Summarynroff script -E option [PATCH] nroff script -E option
    2018-02-16 schwarze Severity3 - Normal 1 - Wish
        Item GroupNone Feature change
    2015-02-18 sayama Attached File- Added nroff_disable_warn.patch, #33113

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code