bugGNU GRUB - Bugs: bug #43727, Cryptomount support for hyphens in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #43727: Cryptomount support for hyphens in UUID

Submitter:  John Lane <johnlane>
Submitted:  Sat 29 Nov 2014 07:58:22 PM UTC
Votes: 50
 
Category:  Disk & Partition Severity:  Major
Priority:  3 - Low Item Group:  None
Status:  None Privacy:  Public
Assigned to:  None Originator Name: 
Open/Closed:  Open Release:  Git master
Release:  Reproducibility:  None
Planned Release:  2.03+

Sun 07 Dec 2014 05:12:11 PM UTC, comment #3: 

the name is not meant to be modified. better way would be to have a specialised comparison function. Patches belong to ML, not to bugtracker.

Vladimir Serbinenko <phcoder>
Group administrator
Sun 30 Nov 2014 11:59:05 AM UTC, comment #2: 

Revised patch added #32574 that replaces #32570 which can be discarded.

This patch implements cryptomount support for UUID values containing hyphens:

cryptomount -u af4b9159-8cbb-4122-b801-0c18adf26b3e

and

(cryptouuid/da9253f8-14ec-43df-8e79-fdf66f71adc8)

both work with hyphens in UUID. They still work without hyphens too.

John Lane <johnlane>
Sat 29 Nov 2014 09:06:44 PM UTC, comment #1: 

The patch allows the -u arg to cryptomount to contain hyphens but a similar thing needs to be done where input is a device specification like

     (cryptouuid/<uuid>)

I am not sure where in the code this would be, I will try to find it but if someone with appropriate knowledge could apply the same change to the relevant area that would be good.

Meanwhile, I'll update here with another patch if I work out how to do it.

John Lane <johnlane>
Sat 29 Nov 2014 07:58:22 PM UTC, original submission:  

The cryptomount command accepts a UUID if given the -u argument but it does not accept a RFC4122 formatted UUID - one that contains hyphens.

Attached patch to cryptodisk.c erases hyphens from the UUID given as a command-line argument.

John Lane <johnlane>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #32574:  0001-Cryptomount-support-for-hyphens-in-UUID.patch added by johnlane (1KiB - text/x-patch - Replaces file #32570. Patch diff against commit 343dad410eaa37f4f02eff6a4a4114102d211a28)
file #32570:  0001-Cryptomount-support-for-hyphens-in-UUID.patch added by johnlane (776B - text/x-patch - Patch diff against commit 343dad410eaa37f4f02eff6a4a4114102d211a28)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by kriswebdev (Voted in favor of this item)
  • -email is unavailable- added by phcoder (Posted a comment)
  • -email is unavailable- added by johnlane (Submitted the item)
  •  

    There are 50 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-10-11 phcoder Priority5 - Normal 3 - Low
    2016-04-08 kriswebdev Carbon-Copy- Added kriswebdev
    2016-03-02 phcoder Planned ReleaseNone 2.03+
    2014-11-30 johnlane Attached File- Added 0001-Cryptomount-support-for-hyphens-in-UUID.patch, #32574
    2014-11-29 johnlane Attached File- Added 0001-Cryptomount-support-for-hyphens-in-UUID.patch, #32570

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code