bugGNU CSSC - Bugs: bug #43360, #error "Please include...

 
 

bug #43360: #error "Please include config.h first."

Submitter:  Ryan Carsten Schmidt <ryandesign>
Submitted:  Sun 05 Oct 2014 08:15:35 AM UTC
Votes: 1
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  jay
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 11 May 2019 06:38:15 AM UTC, comment #1: 

I believe this is fixed in CSSC release 1.4.1.

James Youngman <jay>
Group administrator
Sun 05 Oct 2014 08:15:35 AM UTC, original submission:  

CSSC 1.4.0 builds on OS X 10.7 and later, but fails on OS X 10.6 (and possibly earlier) due to the same problem reported on the bug mailing list:


../gl/lib/unistd.h:135:3: error: #error "Please include config.h first."


http://lists.gnu.org/archive/html/bug-cssc/2014-09/msg00003.html

and supposedly fixed with this commit:

http://git.savannah.gnu.org/cgit/cssc.git/commit/?id=9737f41b5d2a49e61061e9f896b5a9ae19e3a3ac

I backported that to 1.4.0 and it now failed to build with a very similar error message with a different source file, version.cc. version.cc doesn't directly include unistd.h, but does include stdio.h; perhaps on this version of OS X stdio.h eventually includes unistd.h. In any case making a similar change to version.cc.in allowed the build to succeed:

https://trac.macports.org/browser/trunk/dports/devel/cssc/files/patch-src-version.cc.in.diff?rev=126199


Side note: I'm unclear why you're sometimes writing:


#include <config.h>


Since it's a file local to your source directory, shouldn't it always be:


#include "config.h"


Ryan Carsten Schmidt <ryandesign>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jay (Updated the item)
  • -email is unavailable- added by egallager (Voted in favor of this item)
  • -email is unavailable- added by ryandesign (Submitted the item)
  •  

    There is 1 vote so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-05-11 jay Open/ClosedOpen Closed
    2019-05-05 jay StatusNone Fixed
        Assigned toNone jay
    2014-10-11 egallager Carbon-Copy- Added egallager

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code