bugGNU roff - Bugs: bug #42970, let clean and distclean descend...

 
 

bug #42970: let clean and distclean descend into gnulib

Submitter:  None
Submitted:  Tue 12 Aug 2014 05:42:51 PM UTC
   
 
Category:  General Severity:  3 - Normal
Item Group:  Build/Installation Status:  Fixed
Privacy:  Public Assigned to:  wl
Open/Closed:  Closed Planned Release:  1.22.3
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 22 Jan 2022 03:05:36 PM UTC, comment #4: 

Sorry--Werner did the commit on this one so it is (was) his.

G. Branden Robinson <gbranden>
Group administrator
Sat 22 Jan 2022 01:13:06 PM UTC, comment #3: 


commit dece38b2cd5e2724836840617ddfafeef4c0737c
Author: Ingo Schwarze <schwarze@openbsd.org>
Date:   Thu Oct 9 20:13:00 2014 +0200

    * Makefile.in: Let `clean' and `distclean' descend into gnulib.

    This fixes Savannah bug #42970.


G. Branden Robinson <gbranden>
Group administrator
Thu 09 Oct 2014 06:15:25 PM UTC, comment #2: 

Last comment is nonsense: This is for `master'.  Patch now applied, thanks.

Werner LEMBERG <wl>
Group administrator
Tue 12 Aug 2014 05:55:30 PM UTC, comment #1: 

[For the record: This bug report is for the new `automake' branch.]

It seems that gnulib is not yet integrated as intended by its developers: All those targets are automatically handled without any additional user intervention if everything is installed as described in gnulib's documentation.

I'm assigning this to Bertrand.

Werner LEMBERG <wl>
Group administrator
Tue 12 Aug 2014 05:42:51 PM UTC, original submission:  

GNULIBDIRS is not included in LIBDIRS for a reason: The gnulib build system doesn't support the do= mechanism, so the $(TARGETS): rule cannot handle it.  However, that doesn't mean there is nothing to do there.

Let's look at which TARGETS are relevant for gnulib:

all: not needed because that's already covered by the $(GNULIBDIRS): rule and the targets depending on it.

distclean: distclean from the top level should descend here.  That's actually important because right now, when you run "make distclean; ./configure; make dist" on the top level then you get a broken tarball containing src/libs/gnulib/Makefile even though the distclean step ought to have cleaned that out.  Using that tarball will fail because gnulib/configure will not be run on the target system.

clean: not quite as important as distclean, but still: clean should clean gnulib, too.

mostlyclean TAGS: not important enough to warrant their own rule, i think.

install_bin install_data realclean extraclean distfiles depend uninstall_sub fonts: not implemented in gnulib.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #31892:  gnulib_clean.patch added by None (804B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by wl (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-22 gbranden Assigned toschwarze wl
    2022-01-22 gbranden CategoryNone General
        Item GroupNone Build/Installation
        Assigned towl schwarze
    2014-10-09 wl StatusNone Fixed
        Assigned tobgarrigues wl
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.22.3
    2014-08-12 wl Assigned toNone bgarrigues
    2014-08-12 None Attached File- Added gnulib_clean.patch, #31892

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code