bugGNU TeXmacs - Bugs: bug #42550, Hyperlinks are not exported to PDF

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #42550: Hyperlinks are not exported to PDF

Submitter:  Miguel de Benito <mdbenito>
Submitted:  Fri 13 Jun 2014 02:36:40 PM UTC
   
 
Category:  Conversion Priority:  7 - High
Item Group:  Error Status:  Fixed
Privacy:  Public Assigned to:  vdhoeven
Originator Name:  Open/Closed:  Closed
Release:  None Release: 
Fixed Release:  None Fixed Release: 
Keywords: 

Sat 19 Mar 2016 02:43:58 PM UTC, comment #5: 

Ahaha! Joris had fixed it even before my earlier comment!

Many thanks Joris and congrats for this svn rev 10000!

Philippe Joyez <pjoyez>
Group Member
Sat 19 Mar 2016 08:38:45 AM UTC, comment #4: 

Actually the patch is not perfect: with this modification the typesetter cannot break the visible part of the link over several lines. This means that if it should extend over more than one line, this ruins the typesetting (even on-screen).

So this is an interim solution that works only in limited cases, or you have too manually subdivide your hlink at line breaks to get the desired layout.

Philippe Joyez <pjoyez>
Group Member
Thu 05 Mar 2015 12:14:36 AM UTC, comment #3: 

I've been using this patch, and it works great. The PDF now has hyperlinks to http URL's as expected. Thanks.

Karl Hegbloom <karlhegbloom>
Sat 22 Nov 2014 07:52:49 PM UTC, comment #2: 

Hi,

  I tested the patch but I can't really tell if it's a good solution. Indeed, Joris would have to verify, given that it basically bypasses a check which has always been there (even though I don't really understand it: why should inaccessible loci be rendered as locus_boxes but accessible ones not?)

As to the issue: the problem seems to be that when nothing else is on the line, typeset_concat is not called because the subtree is not considered a paragraph. I don't know whether this is accurate nor relevant, but I do know that blindly changing bridge_locus_rep to


void
bridge_locus_rep::my_typeset (int desired_status) {
  ttt->insert_parunit(st, ip);
}


"fixes" the issue. It seems reasonable that the bridge_locus should do the same as the concatter when it finds a locus (if this even makes any sense), but since I don't understand their interplay, I will definitely not commit this!

Anyway: thanks! I will definitely use the "fixes". ;)

Miguel de Benito <mdbenito>
Group Member
Thu 06 Nov 2014 07:51:21 PM UTC, comment #1: 

Hi Miguel,

Here is a minimal patch that enables texmacs hlink to generate working hlinks in pdf output. According to the limited testing I have done on documents with moderate complexity, it does the job. Beware however that since I'm far from having a global understanding of the typesetting process and the management of "loci", it could have really bad side effects for some other primitives... Joris should probably check that.

This patch has a small issue, though: if an <hlink||> is alone on its line then the pdf link is not generated. This means that it fails quite ironically for the file attached to the bug report! (and this has side-tracked me for some time...). It might be a bug elsewhere or a clear proof that I don't understand what's going on. In any case this has an easy fix: just add anything before or after the hlink (for instance a space) and it works.



(file #32382)

Philippe Joyez <pjoyez>
Group Member
Fri 13 Jun 2014 02:36:40 PM UTC, original submission:  

The attached file shows that hlink is not exported with the new PDF renderer.

Miguel de Benito <mdbenito>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #32382:  pdf_hlink_patch.txt added by pjoyez (2KiB - text/plain)
file #31544:  test.tm added by mdbenito (211B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by karlhegbloom (Posted a comment)
  • -email is unavailable- added by pjoyez (Updated the item)
  • -email is unavailable- added by mdbenito (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-03-19 pjoyez StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2015-03-23 mdbenito Priority5 - Normal 7 - High
    2014-11-22 mdbenito Assigned toNone vdhoeven
    2014-11-06 pjoyez Attached File- Added pdf_hlink_patch.txt, #32382
    2014-06-13 mdbenito Attached File- Added test.tm, #31544

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code