bugGNU Octave - Bugs: bug #38558, control: @lti/feedback doesn't...

 
 

bug #38558: control: @lti/feedback doesn't check system blocks dimensions

Submitter:  None
Submitted:  Wed 20 Mar 2013 08:13:25 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Jack Olivieri Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * 3.6.2
Operating System:  * GNU/Linux Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 26 Oct 2013 09:40:05 AM UTC, comment #2: 

Thanks for the report. Note that you are using a very outdated version of control (2.3.52), the current version is control 2.6.0. IIRC, this bug has been fixed in control 2.3.53 (hg revision 774). Could you please double-check the current version in the link below if that is the case?

http://sourceforge.net/p/octave/control/ci/default/tree/inst/@lti/feedback.m

Lukas Reichlin <paramaniac>
Sat 26 Oct 2013 09:19:04 AM UTC, comment #1: 

Added maintainer of the control package to the Mail Notification Carbon-Copy List.

Carnë Draug <carandraug>
Group Member
Wed 20 Mar 2013 08:13:25 PM UTC, original submission:  

The function doesn't correctly perform the check on the system blocks dimensions (see function documentation before proceeding).
The check should make sure that the 'feedout' indeces don't exceed the dimension of the output of 'sys1', namely the forward block for the feedback function. Instead, the function performs that check on the local variable 'feedin'.

What the function DOES:
/usr/share/octave/packages/control-2.3.52/@lti/feedback.m:line 131

if (any (feedin > p1 | feedin < 1))
%etc.
endif


What the function SHOULD DO:
/usr/share/octave/packages/control-2.3.52/@lti/feedback.m:line 131

if (any (feedout > p1 | feedout < 1))
%etc.
endif


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by paramaniac (Posted a comment)
  • -email is unavailable- added by carandraug (maintainer of control package)
  • -email is unavailable- added by jordigh (Updated the item)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-05-31 mtmiller StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2013-10-26 carandraug Summary@lti/feedback doesn\'t check system blocks dimensions control: @lti/feedback doesn't check system blocks dimensions
        Carbon-Copy- Added -email is unavailable-
    2013-03-21 jordigh StatusNone Patch Submitted
        SummaryBug in function @lti/feedback @lti/feedback doesn't check system blocks dimensions

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code