bugGnash - The GNU Flash player - Bugs: bug #35635, jemalloc.c uses faulty memory...

 
 

bug #35635: jemalloc.c uses faulty memory management

Submitted by:  None
Submitted on:  Mon 27 Feb 2012 08:38:02 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: masterStatus: Fixed
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 26 Mar 2012 04:28:21 PM UTC, comment #6:

So far as I'm concerned, yes. Though I didn't test it, reporter is anonymous and probably will never get back to you.

Bastiaan Jacques <bjacques>
Project Member
Mon 26 Mar 2012 04:15:55 PM UTC, comment #5:

Importing would be ok too. I assume I can close this bug report though ?

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 26 Mar 2012 03:03:55 PM UTC, comment #4:

I meant importing the standalone version into our tree like we have done with the Mozilla jemalloc (i.e., not using it as a separate library). Although I do like the idea of using a separate library, it remains to be seen whether it would be suitable for our needs.

That said, I only brought it up because the standalone version has a better (read: better performing) fix for this bug.

Bastiaan Jacques <bjacques>
Project Member
Mon 26 Mar 2012 02:39:13 PM UTC, comment #3:

The Gnash version of jemalloc is derived from the Firefox one a few years ago. The main difference between our version is we have support for mallinfo(), which I use for debugging Gnash. But anyway, adding the standalone library is a TODO task, and not related to this bug report, which I believe is fixed. To use the standalone library, we'd need to wait for it to be included in most distributions, although I do see it's in Fedora 16 and Ubuntu Oneiric.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Sun 25 Mar 2012 07:47:43 PM UTC, comment #2:

It should be noted that jemalloc is now developed as a standalone library. [1] Recent changes include a fix for this bug. I would suggest we import that tree after the Mozilla guys do.

[1] http://www.canonware.com/jemalloc/

Bastiaan Jacques <bjacques>
Project Member
Mon 27 Feb 2012 06:01:52 PM UTC, comment #1:

I added the patch with commit #1a6e0d3. Gnash then also passed it's own test suite.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Mon 27 Feb 2012 08:38:02 AM UTC, original submission:

jemalloc.c as of 0.8.10 and current master (27th March 2012) tries unter Linux to mmap anonymous memory until it is granted the address it hinted by mmap's addr parameter. That behaviour is not correct since mmap is not guaranteed to follow that hint and some kernels like PaX-hardened ones never return the hinted address resulting in an endless mmap/munmap loop. cf. https://bugs.gentoo.org/show_bug.cgi?id=396275
for a similar problem under firefox.
A patch to remedy the situation is attached.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #25188:  gnash-aslr-fix.patch added by None (2kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bjacques (Posted a comment)
  • -unavailable- added by rsavoye (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 26 Mar 2012 04:28:21 PM UTCbjacquesStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 27 Feb 2012 06:01:52 PM UTCrsavoyeStatusNone=>Ready For Test
      Assigned toNone=>rsavoye
    Mon 27 Feb 2012 08:38:02 AM UTCNoneAttached File-=>Added gnash-aslr-fix.patch, #25188

    Back to the top


    Powered by Savane 3.1-cleanup