bugmake - Bugs: bug #15641, different behavior with jobserver...

 
 

bug #15641: different behavior with jobserver (-j)

Submitter:  Boris Kolpackov <bosk>
Submitted:  Mon 06 Feb 2006 08:17:12 PM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  bosk Open/Closed:  Closed
Component Version:  4.0 Operating System:  Any
Fixed Release:  3.81 Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 08 Feb 2006 05:30:05 PM UTC, comment #2: 

Fix is in the repository.

Boris Kolpackov <bosk>
Group Member
Wed 08 Feb 2006 05:13:18 PM UTC, comment #1: 

After some debugging it appear that this behavior is due to unhealthy interaction between dontcare inheritance and jobserver logic. In particular, struct child stores pointer to struct file. Later, when the command is completed, the code checks child->file->dontcare to determine whether we need to fail. However, at that point the dontcare flag in struct file instance might already be restored from inherited value to its original value. The fix adds an extra bitfild to the struct child which caches the dontcare flag.

Boris Kolpackov <bosk>
Group Member
Mon 06 Feb 2006 08:17:12 PM UTC, original submission:  

$ make
failing to build mod_a.o
building all

$ make -j 2
failing to build mod_a.o
make: * [mod_a.o] Error 1
make: failing to build mod_b.o
* Waiting for unfinished jobs....
make: * [mod_b.o] Error 1

I wonder how come nobody noticed this before. Makefile is attached.

Boris Kolpackov <bosk>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #2047:  makefile added by bosk (205B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-04-01 psmith Fixed Release4.0 3.81
2006-02-08 bosk StatusNone Fixed
    Open/ClosedOpen Closed
    Fixed ReleaseNone 4.0
2006-02-08 bosk Assigned toNone bosk
2006-02-06 bosk Attached File- Added makefile, #3375

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code