bugfindutils - Bugs: bug #14614, Incorrect C code in findutils...

 
 

bug #14614: Incorrect C code in findutils 4.2.25

Submitter:  pol tuiu <poltuiu>
Submitted:  Thu 22 Sep 2005 10:03:28 AM UTC
 
Category:  None Severity:  3 - Normal
Item Group:  Compilation Failure Status:  Fixed
Privacy:  Public Assigned to:  jay
Originator Name:  stephane despret Open/Closed:  Closed
Release:  4.2.26 Fixed Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Sat 08 Oct 2005 06:38:39 AM UTC, comment #3: 

Oops, I've really checked the fix into CVS now.

James Youngman <jay>
Project Administrator
Mon 03 Oct 2005 11:06:48 PM UTC, comment #2: 

Thanks - this should be fixed in CVS now.

James Youngman <jay>
Project Administrator
Thu 22 Sep 2005 01:20:56 PM UTC, comment #1: 

The code is valid in C99, but some people are still using C89 compilers, so the fix should be applied.

Also, regexprops.c could use some work, too:

if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../gnulib/lib -I../gnulib/lib     -g2 -Wall -Werror -MT regexprops.o -MD -MP -MF ".deps/regexprops.Tpo" -c -o regexprops.o regexprops.c; \
then mv -f ".deps/regexprops.Tpo" ".deps/regexprops.Po"; else rm -f ".deps/regexprops.Tpo"; exit 1; fi
regexprops.c: In function `describe_regex_syntax':
regexprops.c:434: warning: control reaches end of non-void function
regexprops.c: At top level:
regexprops.c:71: warning: 'table_item' defined but not used
regexprops.c:79: warning: 'code' defined but not used
regexprops.c:106: warning: 'begintable_asis' defined but not used

Eric Blake <ericb>
Project Administrator
Thu 22 Sep 2005 10:03:28 AM UTC, original submission:  

There are two minors bugs in findutils : some variables are defined into the body ofthe functions and not in the beginning of the functions.

We are :

  • lib/regextype.c line 148
  • find/find.c line 397

I propose a patch to correct this.

pol tuiu <poltuiu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #3092:  findutils.patch added by poltuiu (917B - application/octet-stream - To correct no-c89 code)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

 

 

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-11-19 jay Open/ClosedOpen Closed
    Release4.2.25 4.2.26
2005-10-03 jay StatusNone Fixed
    Assigned toNone jay
2005-09-22 poltuiu Attached File- Added findutils.patch, #2985
    Carbon-Copy- Added -email is unavailable-

Back to the top


Powered by Savane 3.9