bugphpGroupWare - Bugs: bug #12172, adodb - installation using psql...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #12172: adodb - installation using psql fails

Submitter:  Bettina Gille <ceb>
Submitted:  Mon 28 Feb 2005 02:31:22 PM UTC
   
 
Category:  API - Setup Item Group:  SVN trunk (dev code)
Severity:  4 - Important Priority:  7 - High
Status:  Fixed Privacy:  Public
Assigned to:  fipsfuchs Open/Closed:  Closed
Component Version:  SVN Operating System:  GNU/Linux - Debian
Reproducibility:  None Planned Release:  0.9.18.000
Fixed Release: 

Thu 03 Mar 2005 05:18:03 PM UTC, comment #2: 

I changed following code

include('class.sql_'.$dbms.'inc.php');

to a switch statement.

<smartass>

including files with a variable is a potential security
hole. A switch statement allows you to hardcode the
file, you want to include. It additionally allows you
to react if you choose an unsupported dbms.

</smartass>

Philipp Kamps <fipsfuchs>
Mon 28 Feb 2005 10:02:59 PM UTC, comment #1: 

It needs to changed to 'postgres' ADOdb should never be changed.  If we don't hack it, like we did with phplib, then we can easily import from upstream.  If mods are needed, extend adodb

Cheers

Dave


Dave Hall <skwashd>
Group administrator
Mon 28 Feb 2005 02:31:22 PM UTC, original submission:  

db_type 'psql' does not work in header.inc.php -> have to use 'postgres' to include the postgres adodb class.
'postgres' does not work for the schema_proc setup classes. either we change the schema_proc class or change the string 'psql' to 'postgres' in the adodb class.

next prob:
Fatal error: Call to a member function on a non-object in /phpgroupware/phpgwapi/inc/class.schema_proc.inc.php on line 441

Bettina Gille <ceb>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 2 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-04-23 ceb Open/ClosedOpen Closed
2005-03-03 fipsfuchs StatusNone Fixed

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code