bugGNUstep - Bugs: bug #11360, MinGW: NSTask.m doesn't use...

Group
 
 

bug #11360: MinGW: NSTask.m doesn't use environment

Submitter:  None
Submitted:  Mon 20 Dec 2004 03:31:49 PM UTC
   
 
Category:  Base/Foundation Severity:  4 - Important
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 18 Feb 2005 08:16:44 AM UTC, comment #5: 

Tested this and fixed a few bugs I found.

Richard Frith-Macdonald <CaS>
Group Member
Tue 15 Feb 2005 10:14:57 AM UTC, comment #4: 

Sorry ... must have failed to copy the final version to my linux box from windows before comitting.
Re-comitted now.

Richard Frith-Macdonald <CaS>
Group Member
Mon 14 Feb 2005 10:11:49 PM UTC, comment #3: 

This "Fix" completely broke compilation of NSTask. As of version 1.65 of NSTask.m, it now fails to compile under mingw32. You introduced use of       CREATE_AUTORELEASE_POOL(pool); without #including "Foundation/NSAutoreleasePool.h"

To add insult to injury, even when I fixed this, I still can't compile.

Here's the output of GCC (I'm using 3.2.3), once the above missing header is #included.

Making all for library libgnustep-base...
 Compiling file NSTask.m ...
NSTask.m: In function `-[NSConcreteWindowsTask launch]':
NSTask.m:1118: parse error before ';' token
NSTask.m:1121: parse error before ';' token
NSTask.m:1113: warning: unused variable `expression'
NSTask.m:1114: warning: unused variable `l'
NSTask.m:1115: warning: unused variable `r'
NSTask.m:1116: warning: unused variable `buffer'
NSTask.m:1124: warning: passing arg 1 of `appendBytes:length:' makes pointer from integer without a cast
NSTask.m:1126: warning: assignment discards qualifiers from pointer target type
NSTask.m:1106: warning: unused variable `separator'
make[1]: * [shared_obj/NSTask.o] Error 1
make: * [libgnustep-base.all.library.variables] Error 2

It's not much of a fix if it breaks everything else, you know...

Alex Perez <aperez>
Group Member
Mon 14 Feb 2005 11:05:20 AM UTC, comment #2: 

I applied a modified version of the fix more in the GNUstep coding style and simplified a little.

Richard Frith-Macdonald <CaS>
Group Member
Mon 20 Dec 2004 03:33:17 PM UTC, comment #1: 

(oops) forgot to sign!

thanks a lot!

--andre levy

Anonymous
Mon 20 Dec 2004 03:31:49 PM UTC, original submission:  

using MinGW and CVS version of NSTask.

when a new NSTask is launched, it does not use environment set by -[setEnvironment:]

the reason for that is that the option is not implemented.
in -[NSConcreteWindowsTask launch]
CreateProcess receives a NULL value for environment meaning 'inherit environment from parent process'.

attached is a unified diff for a proposed solution.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #2247:  environ.diff added by None (2KiB - application/octet-stream - environ.diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 9 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-02-18 CaS Open/ClosedIn Test Closed
2005-02-15 CaS StatusNone Fixed
    Open/ClosedOpen In Test
2005-02-14 aperez Severity3 - Normal 4 - Important
    StatusFixed None
    Open/ClosedClosed Open
2005-02-14 CaS StatusNone Fixed
    Open/ClosedOpen Closed
2004-12-20 None Attached File- Added environ.diff, #1988

Back to the top

Powered by Savane 3.13-758e.
Corresponding source code