bugGNUstep - Bugs: bug #10214, Patch for GSXML under amd64

Group
 
 

bug #10214: Patch for GSXML under amd64

Submitter:  Pete French <minusbat>
Submitted:  Sun 29 Aug 2004 06:25:09 PM UTC
   
 
Category:  Base/Foundation Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 01 Nov 2004 08:10:32 AM UTC, comment #1: 

Thanks for the patch.
Rather than change the public API with this patch, I have modified the usage of NSMapTable to (I hope) work properly on a 64bit processor where sizeof(int) != sizeof(void*)
Please let me know if there are any problems with this.

Richard Frith-Macdonald <CaS>
Group Member
Sun 29 Aug 2004 06:25:09 PM UTC, original submission:  

The attached patch changes the 'type' from an int
to a long throughout. This is because it is stored in
a void* in the NSMapTable which is longer than an int
on amd64. This may not be a problem when storing, but
could be on retrieval as a void** was being passed with
the address of an int. It also changes the way the hash is
calculated slightly to remove a waning and retain as
much uniqueness as possible.

As the sizeof an int and a long are the same on all
other architectures then this patch does not affect
operation on non amd64 systems in any way. It passes
the guile GSXML test on those systems.

Pete French <minusbat>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #1696:  gsxml.diff added by minusbat (9KiB - application/octet-stream - Patchfile for GSXML.m and GSXML.h)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2004-11-01 CaS StatusNone Fixed
    Open/ClosedOpen Closed
2004-08-29 minusbat Attached File- Added gsxml.diff, #1625

Back to the top

Powered by Savane 3.13-758e.
Corresponding source code