bugGNU roff - Bugs: bug #66322, [mom] Git HEAD doesn't have any...

 
 

bug #66322: [mom] Git HEAD doesn't have any bottom margins(?) and doesn't output page numbers anymore

Submitter:  None
Submitted:  Fri 11 Oct 2024 01:45:02 PM UTC
   
 
Category:  Macro package mom Severity:  3 - Normal
Item Group:  Incorrect behaviour Status:  Fixed
Privacy:  Public Assigned to:  PTPi
Open/Closed:  Closed Planned Release:  1.24.0
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Jump to the original submission

Mon 14 Oct 2024 04:37:34 AM UTC, comment #11: 

Apparently Debian carries d/p/papersize-config.patch that replaces the constant default with reading /etc/papersize, hence why I was getting the A4 w/o config on previous releases, but not on HEAD. My b.

Anonymous
Mon 14 Oct 2024 04:19:17 AM UTC, comment #10: 

Addressing each:
1. What "supposed requirement for -Tps"?  Do you mean the requirement that papersize be given on the command line?  That has always been the case.  Or is it some other supposed requirement for -Tps that I've missed in this thread?  I'm recovering from eye surgery and scanning through text ain't easy.

2. The output page size has always been correct by default when pdfmom is run without -Tps.  Are you saying this is no longer the case?

Peter Schaffter <PTPi>
Group Member
Mon 14 Oct 2024 03:48:35 AM UTC, comment #9: 

The supposed requirement for -Tps and the output page size no longer being correct by default, resp.

Anonymous
Mon 14 Oct 2024 03:32:52 AM UTC, comment #8: 

Me no understand.  What is the antecedent for the "this" you describe as "not real"?  And since I am getting clean results with the master branch pdfmom and om.tmac, what has regressed?

Peter Schaffter <PTPi>
Group Member
Mon 14 Oct 2024 03:07:14 AM UTC, comment #7: 

Well, considering that bookworm (1.22.4-10) and sid (1.23.0-5) groff's "pdfmom -Tps -K utf-8 good.mom" both produce a 1123/793≈1.41=correct ratio postscript and groff HEAD (same as before) yields a 1056/816≈1.29=wrong ratio postscript, I'm included to describe this as "not real" and a regression.

(file #56520, file #56521, file #56522)

Anonymous
Mon 14 Oct 2024 02:35:08 AM UTC, comment #6: 

Assuming 'good-gaming' and 'good' are identical (I don't have the source for 'good-gaming'), and that the recently committed om.tmac on the master branch is used
   pdfmon -Tps -Kutf8 -P-pa4 good.mom > good.ps
produces clean output.  See attached 'good-clean.ps'.

Mom's default papersize is US letter, but this file calls for A4.  When -Tps is given to pdfmom, the papersize must be given on the command line as well.  There's an entry in the docs about it.  I'm wondering if the OP remembered -P-pa4.  Neglecting it results in wrong bottom margins and missing page numbers.  (Without -Tps, pdfmom does not need -P-p<size>.)

The wrong colours problem stems from the use of .gcolor in the DRV and other graphical object macros when they set the rule colour.  .COLOR, rather than .gcolor, needs to be used so .XCOLOR aliases can be passed to graphical object macros.

While I'm at it, I should mention that I uncovered some wonkiness in the left margin placement of graphical objects.  You don't notice it when the rule weight is a point or less, but when the rule becomes heavier, say 4 points, you can see that objects are slightly to the right of the desired location.

Both these issues will be dealt with in my next commit.

(file #56519)

Peter Schaffter <PTPi>
Group Member
Sun 13 Oct 2024 06:42:04 PM UTC, comment #5: 

(bookworm 1.22.4-10 of course)

Anonymous
Sun 13 Oct 2024 06:40:21 PM UTC, comment #4: 

Don't think this is fixed. Compare good-gaming.ps (8740fa141) with good-gaming-24.ps (bookworm 1.24). Beside the pages being different sizes(?), and the colours being different(?), page 2 doesn't have a bottom margin at all, and pages 3 and 4 don't have a page number,

(file #56517, file #56518)

Anonymous
Sun 13 Oct 2024 06:28:26 PM UTC, comment #3: 


commit 8c76ad454f1199cbfe465cc8d6327f6908728451
Author: Peter Schaffter <peter@schaffter.ca>
Date:   Sun Oct 13 13:48:55 2024 -0400

    [mom]: [om.tmac] Add linked endnotes; fix graphical objects; tweaks

      * adds internally linked endnotes
      * fixes graphical objects clobbering bottom of footer trap
        - move restoration of traps to the bottom of affected macros
      * resets $QUAD_VALUE before exiting ENDNOTE
      * tweaks QUOTE/BLOCKQUOTE and centred/right LISTs so they play
        nice with line numbering
      * makes UNDERSCORE2 clobber UNDERSCORE and vice versa in
        HEADING_STYLE
      * TYPEWRITE: fix spacing before first para after docheader

commit 022e87dcd0ebd269e2a02ca8f092ab08b97e987a
Author: Peter Schaffter <peter@schaffter.ca>
Date:   Sun Oct 13 13:55:03 2024 -0400

    [mom]: Update BUGS, NEWS

commit b6b2851a7adfd260e41ab3bda6a0392d2ec72526
Author: Peter Schaffter <peter@schaffter.ca>
Date:   Sun Oct 13 13:57:09 2024 -0400

    [mom]:[examples]: Small fix to sample_docs.mom for TYPEWRITE

commit 8740fa141ef597530e51e6057af5392b48537dcb
Author: Peter Schaffter <peter@schaffter.ca>
Date:   Sun Oct 13 14:02:02 2024 -0400

    [mom]: Update and emend docs


G. Branden Robinson <gbranden>
Group administrator
Sat 12 Oct 2024 03:19:30 AM UTC, comment #2: 

It's a bug in DRV.  All the graphical objects macros, in fact.  The fix will be in my next commit, probably in the next couple of days.

Peter Schaffter <PTPi>
Group Member
Fri 11 Oct 2024 03:40:08 PM UTC, comment #1: 

Reassigning to Peter.

G. Branden Robinson <gbranden>
Group administrator
Fri 11 Oct 2024 01:45:02 PM UTC, original submission:  

Originally found in the course of https://bugs.d ... an.org/1082520

See attachments that demo this (source and pdfmom -Tps -K utf-8 $f.mom > $f.ps).

Renders fine on bookworm 1.24.4 and sid 1.30.0.
Here's a correct render from sid: https://srhtcdn.g ... f9eb7da/n3359.pdf

Anonymous

 

Attached Files

Attached Files
file #56520:  good-22.ps added by None (45KiB - application/postscript)
file #56521:  good-HEAD.ps added by None (45KiB - application/postscript)
file #56522:  good-23.ps added by None (38KiB - application/postscript)
file #56519:  good-clean.ps added by PTPi (45KiB - application/postscript)
file #56517:  good-gaming.ps added by None (45KiB - application/postscript)
file #56518:  good-gaming-24.ps added by None (54KiB - application/postscript)
file #56498:  good.mom added by None (9.4KiB - application/octet-stream)
file #56499:  good.ps added by None (45KiB - application/postscript)
file #56500:  n3359.mom added by None (14KiB - application/octet-stream)
file #56501:  n3359.ps added by None (54KiB - application/postscript)

(Note: upload size limit is set to 4.0MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by PTPi (Posted a comment)
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by gbranden (original submitter)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    History

    Follow 17 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-10-14 None Attached File- Added good-22.ps, #56520
        Attached File- Added good-HEAD.ps, #56521
        Attached File- Added good-23.ps, #56522
    2024-10-14 PTPi Attached File- Added good-clean.ps, #56519
    2024-10-13 None Attached File- Added good-gaming.ps, #56517
        Attached File- Added good-gaming-24.ps, #56518
    2024-10-13 gbranden Summary[mom]: groff HEAD doesn't have any bottom margins(?) and doesn't output page numbers anymore [mom] Git HEAD doesn't have any bottom margins(?) and doesn't output page numbers anymore
    2024-10-13 gbranden StatusNone Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.24.0
    2024-10-11 gbranden Assigned toNone PTPi
        Summarygroff HEAD mom doesn't have any bottom margins(?) and doesn't output page numbers anymore [mom]: groff HEAD doesn't have any bottom margins(?) and doesn't output page numbers anymore
    2024-10-11 gbranden Carbon-Copy- Added -email is unavailable-
    2024-10-11 None Attached File- Added good.mom, #56498
        Attached File- Added good.ps, #56499
        Attached File- Added n3359.mom, #56500
        Attached File- Added n3359.ps, #56501

    Back to the top

    Powered by Savane 3.16-8b18.
    Corresponding source code