buggnubg - Bugs: bug #65639, `show marketwindow' Crawford...

 
 

bug #65639: `show marketwindow' Crawford checkbox still active 2+away-2+away

Submitter:  TAKAHASHI Kaoru <kaoru>
Submitted:  Wed 24 Apr 2024 07:57:49 PM UTC
   
 
Originator Name:  TAKAHASHI Kaoru Item Group:  * Other bug
Category:  * Graphical User Interface Release:  * 1.08
Privacy:  Public Operating System:  * All
Severity:  3 - Normal Open/Closed:  Open
Assigned to:  None Priority:  5 - Normal
Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 25 Apr 2024 04:21:19 AM UTC, comment #2: 

comment #1:

> I can't decide what the behavior of 1away-2away -> 1away-1away should be.
>
>  1) Crawford checkbox activation is still saved. Insensitive checkbox.


If you adopt 1), please use the following conditional instead.

    if ((ci.anScore[0] != ci.nMatchTo - 1) && (ci.anScore[1] != ci.nMatchTo - 1)) {
            /* Crawford impossible score (expect DMP) */
            ci.fCrawford = 0;
            gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(ptw->pwCrawford), FALSE);
    }


TAKAHASHI Kaoru <kaoru>
Wed 24 Apr 2024 08:47:52 PM UTC, comment #1: 

I can't decide what the behavior of 1away-2away -> 1away-1away should be.

 1) Crawford checkbox activation is still saved. Insensitive checkbox.
 2) Crawford checkbox deactivate and insensitive checkbox. (my patch)
 3) Crawford checkbox activation is still saved. Sensitive checkbox. (XG2 cube information)

TAKAHASHI Kaoru <kaoru>
Wed 24 Apr 2024 07:57:49 PM UTC, original submission:  

In `show marketwindow'

 - Set 1away-4away matchscore
 - Active Crawford checkbox & cube 1
 - Set 2away-4away matchscore

Shows Crawford(?) 2away-4away market window.
I expected normal (non-Crawford) 2away-4away market window.


I'll patch attach later.
- non-1away non-1away score deactivate checkbox & 1-cube
- 1away-1away (DMP) deactivate checkbox
- When active Crawford checkbox, set 1-cube & non-sensitive cubesize

TAKAHASHI Kaoru <kaoru>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #55973:  0001-Deactivate-crawford-checkbox-according-to-score-bug-.patch added by kaoru (2KiB - text/x-diff - New `git format-patch'. the 0000 format-patch have bug in reset after money/match toggled.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by kaoru (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-04-24 kaoru Attached File- Added 0001-Deactivate-crawford-checkbox-according-to-score-bug-.patch, #55973
    2024-04-24 kaoru Attached File- Added 0001-Deactivate-crawford-checkbox-according-to-score-bug-.patch, #55972

    Back to the top

    Powered by Savane 3.13-12ab.
    Corresponding source code