bugGNU roff - Bugs: bug #64122, [tbl] numeric overflow when...

 
 

bug #64122: [tbl] numeric overflow when restoring hyphenation margin and spacing

Submitter:  G. Branden Robinson <gbranden>
Submitted:  Fri 28 Apr 2023 10:17:52 AM UTC
   
 
Category:  Preprocessor tbl Severity:  3 - Normal
Item Group:  Incorrect behaviour Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.24.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 10 Jul 2023 08:40:08 AM UTC, comment #2: 


commit ad4d3fb78dfd14d466ee8f468b8ab4c7b4754554
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Apr 28 06:16:10 2023 -0500

    [tbl]: Fix Savannah #64122.

    * src/preproc/tbl/table.cpp (table::init_output): Specify scaling unit
      when using `hym` and `hys` requests.  Continues commit cee547e883, 30
      January 2021.

    Thanks to Frederic Chartier and Peter Schaffter for the report.


There's also a regression test for it.


commit c2033f0d36374af86d21750489deaa789e8513ed
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Apr 28 06:15:38 2023 -0500

    [tbl]: Regression-test Savannah #64122.

    * src/preproc/tbl/tests/save-and-restore-hyphenation-parameters.sh:
      Update input and add check.

    Test fails at this commit.


G. Branden Robinson <gbranden>
Group administrator
Fri 28 Apr 2023 07:24:22 PM UTC, comment #1: 

As this is on a branch, commit IDs (and content, for that matter) are subject to change.


commit 14d1cb181cb1a3057cfca2d6706a27baec82cb15
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Apr 28 06:16:10 2023 -0500

    [tbl]: Fix Savannah #64122.

    * src/preproc/tbl/table.cpp (table::init_output): Specifying scaling
      unit when using `hym` and `hys` requests.  Continues commit
      cee547e883, 30 January 2021.

    Thanks to Frederic Chartier and Peter Schaffter for the report.

commit 136e8c9142c5ce481e0056929fb9d7cfcf8e87fc
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Apr 28 06:15:38 2023 -0500

    [tbl]: Regression-test Savannah #64122.

    * src/preproc/tbl/tests/save-and-restore-hyphenation-parameters.sh:
      Update input and add check.

    Test fails at this commit.


G. Branden Robinson <gbranden>
Group administrator
Fri 28 Apr 2023 10:17:52 AM UTC, original submission:  

This is a post-groff 1.22.4 problem; groff 1.22.4 didn't restore these document parameters at all, meaning that a tbl(1) text block that manipulated them could screw up the rest of the input.

Background:

https://lists.gnu.org/archive/html/groff/2023-04/msg00258.html
https://lists.gnu.org/archive/html/groff/2023-04/msg00313.html

Illustration:

$ cat ./EXPERIMENTS/hym-and-hys.roff
.hym 10m
.hys 5m
.tm before: .hym=\n[.hym], .hys=\n[.hys]
.TS
L.
foo
.TE
.nf
.tm after: .hym=\n[.hym], .hys=\n[.hys]
.if !((\n[.hym] = 10m) & (\n[.hys] = 5m)) .ab
$ ./build/test-groff -tz ./EXPERIMENTS/hym-and-hys.roff
before: .hym=100000, .hys=50000
after: .hym=1000000000, .hys=500000000



G. Branden Robinson <gbranden>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-07-10 gbranden StatusReady for Merge Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.24.0
    2023-04-28 gbranden StatusIn Progress Ready for Merge

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code