bugGNU roff - Bugs: bug #64037, [mdoc] ensure long tables don't...

 
 

bug #64037: [mdoc] ensure long tables don't get blank lines in their midst when continuously rendering

Submitter:  G. Branden Robinson <gbranden>
Submitted:  Wed 12 Apr 2023 07:10:09 PM UTC
   
 
Category:  Macro mdoc Severity:  3 - Normal
Item Group:  Test Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.24.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 10 Jul 2023 09:07:16 AM UTC, comment #5: 


commit 1623f984a2f6c563ee1c761df566b560d821b08e
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Apr 22 03:13:30 2023 -0500

    [mdoc]: Regression-test Savannah #57665 for mdoc.

    * tmac/tests/doc_TS-do-not-keep-tables-when-cR-set.sh: Do it.
    * tmac/tmac.am (tmac_TESTS): Run test.

    Fixes <https://savannah.gnu.org/bugs/?64037>.


G. Branden Robinson <gbranden>
Group administrator
Thu 01 Jun 2023 03:10:37 PM UTC, comment #4: 

Moving to item group "Test", since the behavior is already correct.  We want to have a regression test for it as man(7) already does.

G. Branden Robinson <gbranden>
Group administrator
Fri 28 Apr 2023 07:28:09 PM UTC, comment #3: 

Fixed on branch.  Subject to change.


commit 832757d01ff83e131cb2f8c29aed1874fb421464
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Apr 22 03:13:30 2023 -0500

    [mdoc]: Regression-test Savannah #57665 for mdoc.

    * tmac/tests/doc_TS-do-not-keep-tables-when-cR-set.sh: Do it.
    * tmac/tmac.am (tmac_TESTS): Run test.

    Fixes <https://savannah.gnu.org/bugs/?64037>.


G. Branden Robinson <gbranden>
Group administrator
Sat 22 Apr 2023 08:03:54 AM UTC, comment #2: 

Affects groff 1.22.4.

I already fixed this, but had completely forgotten about it.


commit 1276643049b9e297651a1a6403f3463daa797713
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Jun 19 23:25:02 2021 +1000

    [mdoc]: Set usekeeps register used by tbl(1).

    * tmac/mdoc/doc-nroff-u: Set the usekeeps register used by tbl to the
      logical complement of the cR (continuous rendering) register.  This
      prevents blank lines from creeping into tables in that mode.

    Exposed by 971dc619 (earlier today).


But now I have a separate regression test for it, which will be handy if/when we go ahead with the "\n[.R] = INT_MAX, .pl \n[.R]u" thing.

G. Branden Robinson <gbranden>
Group administrator
Wed 12 Apr 2023 07:37:14 PM UTC, comment #1: 


original submission:

> 3.  Our mdoc implementation has no special support for tbl tables at all.  I would have thought this meant that we didn't render those tables for HTML output at all, because the `HTML-IMAGE` and `HTML-IMAGE-END` tags were missing.  However, startlingly, tables appear just fine.  (Albeit as images of converted PostScript output--see bug #60052.)
>
> 4.  So maybe our man(7) doesn't need those tags either, and we can simplify its `TS` and `TE` definitions.  Investigate this.


www.tmac provides fallback definitions of these.  man(7) overrides them because it needs to handle continuous rendering issues (though HTML is effectively continuous rendering as well...).  mdoc(7) should do the same, but doesn't.

G. Branden Robinson <gbranden>
Group administrator
Wed 12 Apr 2023 07:10:09 PM UTC, original submission:  

This is related to bug #57665, which was a continuous rendering/tbl/man interaction problem.

The same problem affects mdoc, but I did not investigate the problem for that macro package.

So the fix for the man part of #57665 needs to be ported to mdoc.

However:

1.  That fix introduced a different problem; ugly, misplaced vertical rules; see bug #63960.  It's a lesser problem because it only affects tables with vertical rules, not all tables.

2.  The fix for that newer bug is pretty crude and I think we want a better one, which I have in mind and am working on presently.

3.  Our mdoc implementation has no special support for tbl tables at all.  I would have thought this meant that we didn't render those tables for HTML output at all, because the `HTML-IMAGE` and `HTML-IMAGE-END` tags were missing.  However, startingly, tables appear just fine.  (Albeit as images of converted PostScript output--see bug #60052.)

4.  So maybe our man(7) doesn't need those tags either, and we can simplify its `TS` and `TE` definitions.  Investigate this.

G. Branden Robinson <gbranden>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-07-10 gbranden StatusReady for Merge Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.24.0
    2023-04-28 gbranden StatusIn Progress Ready for Merge
    2023-04-22 gbranden Item GroupIncorrect behaviour Test
        Summary[mdoc] long tables get blank lines in their midst when continuously rendering [mdoc] ensure long tables don't get blank lines in their midst when continuously rendering
    2023-04-12 gbranden Summary[mdoc] long tables get blank lines in their midst in nroff mode [mdoc] long tables get blank lines in their midst when continuously rendering

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code