bugGNU roff - Bugs: bug #59563, [PATCH] mm/5.MT: macro...

 
 

bug #59563: [PATCH] mm/5.MT: macro 'cov@print-title' lacks a check for macro 'cov*title'

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Sat 28 Nov 2020 01:37:25 AM UTC
   
 
Category:  Macro mm Severity:  3 - Normal
Item Group:  Warning/Suspicious behaviour Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 30 May 2021 03:15:36 PM UTC, comment #1: 


commit 58c4b2aec327989991c34c534775c094c91900f9
Author: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date:   Sat Nov 28 01:37:25 2020 +0000

    contrib/mm/mm/5.MT: Fix missing diagnostic.

    * contrib/mm/mm/5.MT (cov@print-title): Fix missing diagnostic.

    Fixes <https://savannah.gnu.org/bugs/?59563>.

    Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>


G. Branden Robinson <gbranden>
Group administrator
Sat 28 Nov 2020 01:37:25 AM UTC, original submission:  

contrib/mm/mm/5.MT: macro 'cov@print-title' lacks a check for macro 'cov*title'

  Test run from file in #24049

test-groff -mm -z test.sig.mm

troff: backtrace: file '/home/bg/git/groff/build/../contrib/mm/m.tmac':365
troff: /home/bg/git/groff/build/../contrib/mm/m.tmac:365: warning: can't find macro file 'mm/locale'
troff: backtrace: '/home/bg/git/groff/build/../contrib/mm/mm/5.MT':32: macro 'cov@print-title'
troff: backtrace: file '/home/bg/git/groff/build/../contrib/mm/mm/5.MT':49
troff: backtrace: '/home/bg/git/groff/build/../contrib/mm/m.tmac':3100: macro 'MT'
troff: backtrace: file 'test-sig.mm':128
troff: /home/bg/git/groff/build/../contrib/mm/mm/5.MT:49: warning: macro 'cov*title' not defined
...

  A check like that in "mm/mm/4.MT" is missing:

.if !d cov*title .@error title (.TL) not defined!

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 contrib/mm/mm/5.MT | 1 +
 1 file changed, 1 insertion(+)

diff --git a/contrib/mm/mm/5.MT b/contrib/mm/mm/5.MT
index e11d5b26..f28ad2a6 100644
--- a/contrib/mm/mm/5.MT
+++ b/contrib/mm/mm/5.MT
@@ -26,6 +26,7 @@ http://savannah.gnu.org/bugs/?group=groff.
 .\"------------
 .nr cov*mt0-ind 1.1c
 .de cov@print-title
+.if !d cov*title .@error title (.TL) not defined!
 .B
 .ll 9c
 .fi
--
2.29.2


Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Updated the item)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-05-30 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.23.0
    2021-05-30 gbranden StatusNone In Progress
        Assigned toNone gbranden

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code