GNU nano - Bugs: bug #58424, the Go syntax doesn't highlight...
You are not allowed to post comments on this tracker with your current authentication level.
bug #58424: the Go syntax doesn't highlight "chan"
Submitter: | Ryan Westlund <yujiri> | ||
Submitted: | Thu 21 May 2020 03:22:14 PM UTC | ||
Severity: | 2 - Minor | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Closed |
Jump to the original submission
Thu 30 Jul 2020 07:13:41 AM UTC, comment #6: |
Benno Schulenberg <bens> |
Tue 26 May 2020 02:58:17 PM UTC, comment #5: Thanks. Applied to master, commit 3480518a, with a tweaked commit message.
|
Benno Schulenberg <bens> |
Mon 25 May 2020 02:12:17 PM UTC, comment #4: Ah. I'm still a bit confused by these patch-related git commands since I don't use them often. I'm attaching a new file. |
Ryan Westlund <yujiri> |
Mon 25 May 2020 10:18:20 AM UTC, comment #3: Thanks for the patch. However, please provide it as a proper git patch, with a commit message and a signed-off-by line. Also, I would keep the "chan" by itself in the original regex, and only add a separate regex for the chan plus the "arrows". |
Benno Schulenberg <bens> |
Sun 24 May 2020 09:25:59 PM UTC, comment #2: I believe the relevant documentation is here: https://golang.org/ref/spec#Channel_types
|
Ryan Westlund <yujiri> |
Thu 21 May 2020 05:54:50 PM UTC, comment #1: Indeed, there is obviously something wrong with the regex that contains "chan": "\<<" and similar will never match. If you wish, please provide a patch that fixes this.
|
Benno Schulenberg <bens> |
Thu 21 May 2020 03:22:14 PM UTC, original submission:
The go.nanorc file includes expressions for chan in the regex, but as far as I can tell, fails to ever color the word. I found that I could only get it to work by removing the \<...\> enclosing. My understanding is that that enclosing matches things as words, which prevents regexes involving <- and -> from being matched?
|
Ryan Westlund <yujiri> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2020-07-30 | bens | Open/Closed | Open | Closed | |
2020-05-26 | bens | Status | In Progress | Fixed | |
2020-05-25 | yujiri | Attached File | - | Added 0001-Improve-go.nanorc.patch, #49166 | |
2020-05-25 | bens | Status | None | In Progress | |
Assigned to | None | bens | |||
Summary | go.nanorc doesn't highlight "chan" | the Go syntax doesn't highlight "chan" | |||
2020-05-24 | yujiri | Attached File | - | Added go.patch, #49163 | |
2020-05-21 | bens | Severity | 3 - Normal | 2 - Minor | |
Summary | go.nanorc doesn't highlight chan | go.nanorc doesn't highlight "chan" |
Powered by Savane 3.13-758e.
Corresponding source code
Released in nano-5.0.