GNU GRUB - Bugs: bug #57652, minix filesystem detection too...
You are not allowed to post comments on this tracker with your current authentication level.
bug #57652: minix filesystem detection too optimistic
Submitter: | Stefan Seyfried <seife> | ||
Submitted: | Wed 22 Jan 2020 08:24:04 AM UTC | ||
Category: | Filesystem | Severity: | Major |
Priority: | 5 - Normal | Item Group: | Software Error |
Status: | None | Privacy: | Public |
Assigned to: | None | Originator Name: | |
Open/Closed: | Open | Release: | 2.02 |
Release: | Reproducibility: | Every Time | |
Planned Release: | None |
Fri 24 Jan 2020 10:10:20 AM UTC, comment #2: |
Stefan Seyfried <seife> |
Wed 22 Jan 2020 10:24:56 AM UTC, comment #1: Adding a reproducer script.
|
Stefan Seyfried <seife> |
Wed 22 Jan 2020 08:24:04 AM UTC, original submission:
I encountered an intermittent issue where grub-install would fail with "not a directory" error after trying minix_be detection:
|
Stefan Seyfried <seife> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2020-01-22 | seife | Attached File | - | Added grub-bug-57652-reproduce.sh, #48272 | |
2020-01-22 | seife | Attached File | - | Added grub2-minix-probe-fix.diff, #48271 | |
Carbon-Copy | - | Added seife |
Powered by Savane 3.13-758e.
Corresponding source code
maybe a non-intrusive fix would be to ensure that ext2 gets initialized before minix:
diff --git a/Makefile.am b/Makefile.am
index 1f4bb9b8c..0bef226d3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -42,8 +42,11 @@ libgrub.pp: grub_script.tab.h grub_script.yy.h $(libgrubmods_a_SOURCES) $(libgru
-D'GRUB_MOD_INIT(x)=@MARKER@x@' $^ > $@ || (rm -f $@; exit 1)
CLEANFILES += libgrub.pp
+# the grep/sed ensures that ext2 gets initialized before minix*
+# see https://savannah.gnu.org/bugs/?57652
libgrub_a_init.lst: libgrub.pp
cat $< | grep '@MARKER@' | sed 's/@MARKER@\(.*\)@/\1/g' | sort -u > $@ || (rm -f $@; exit 1)
+ if grep ^ext2 $@ >/dev/null; then sed '/ext2/d;/newc/iext2' < $@ > $@.tmp && mv $@.tmp $@; fi
CLEANFILES += libgrub_a_init.lst
libgrub_a_init.c: libgrub_a_init.lst $(top_srcdir)/geninit.sh