bugGNU nano - Bugs: bug #57398, [Task] get rid of the global...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #57398: [Task] get rid of the global 'meta_key' -- merge it into the keycode

Submitter:  Benno Schulenberg <bens>
Submitted:  Thu 12 Dec 2019 11:07:05 AM UTC
   
 
Severity:  1 - Wish Status:  Wont Fix
Assigned to:  None Open/Closed:  Closed

Fri 15 May 2020 03:20:59 PM UTC, comment #1: 

In January and February some changes were made to elide unneeded references to meta_key.  As things are now, it doesn't look like it would be any faster or shorter to have meta_key merged into the keycode.

Benno Schulenberg <bens>
Group administrator
Thu 12 Dec 2019 11:07:05 AM UTC, original submission:  

It is somewhat annoying that a keystroke is not fully determined by a single keycode, but only by 'keycode' and 'meta_key' jointly.  Things would be more straightforward if the Meta status of the keystroke were merged into the keycode.

The fixed keycodes of ncurses are all below 0x200, and the dynamically assigned ones start at 0x200 and will not cover more than a few dozen.  The surrogate keycodes defined in src/nano.h start at 0x400 and don't go beyond 0x500.

So... if we OR the keycode with 0x800 to indicate that it is a Meta keystroke (that is: Alt was held), then we have a single code to uniquely identify each key combo.

Benno Schulenberg <bens>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-05-15 bens Open/ClosedOpen Closed
    2020-05-15 bens StatusNone Wont Fix

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code