bugGNU roff - Bugs: bug #57034, [PATCH] [mm] author title (AT)...

 
 

bug #57034: [PATCH] [mm] author title (AT) does not display in signature (SG)

Submitter:  Ken Mandelberg <kmand>
Submitted:  Thu 10 Oct 2019 05:37:16 PM UTC
   
 
Category:  Macro mm Severity:  3 - Normal
Item Group:  Feature change Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 30 May 2021 03:16:42 PM UTC, comment #5: 


commit a1bec1e178d66f383acc9b1ff2c654f496d68112
Author: Tadziu Hoffmann <hoffmann@usm.uni-muenchen.de>
Date:   Tue Mar 16 12:38:41 2021 +0100

    Fix Savannah #57034.

    * contrib/mm/m.tmac (AT): Count author title declarations.

      (let*mt-sign): Use correct index when iterating author names.  Prevent
      page break between author names and titles.  Iterate author titles and
      write them.

    Fixes <https://savannah.gnu.org/bugs/?57034>.


G. Branden Robinson <gbranden>
Group administrator
Sun 30 May 2021 10:16:04 AM UTC, comment #4: 

Here's another example that works nicely now.

I don't know about this "--/" notation, but that seems like a separate issue.  I think it's one Werner raised in bug #24049.


$ cat EXPERIMENTS/57034b.mm
.TL
Inquiry
.AU "John SMITH"
.AT "Director"
.AU "Dick JONES"
.AT "Senior Vice President"
.MT 5
.P
sentence
.FC Sincerely,
.SG


Output:


$ ./build/test-groff -Wfile -Tutf8 -mm EXPERIMENTS/57034b.mm | cat -s

       Inquiry

                                                       May 30, 2021

       sentence

                                     Sincerely,

                                     John SMITH
                                     Director

       ‐‐/                           Dick JONES
                                     Senior Vice President


G. Branden Robinson <gbranden>
Group administrator
Sun 30 May 2021 09:37:09 AM UTC, comment #3: 

Consequent to fixing bug #59563 (thanks to Bjarni), memorandum type 5 will now require a title.  I'm adding this to the NEWS file for the next release.

I trust that won't be too disruptive.  I suspect most people using MT 5 are learners trying to get started with mm, or developers exploring it.  From a use-case perspective and my experience with organizations, it seems implausible that an "external letter" (groff_mm(7)) should be permitted to go out without a subject line.

Here's a new sample input file.


.TL
Inquiry
.AU "John SMITH"
.AT "Director"
.MT 5
.P
sentence
.FC Sincerely,
.SG


G. Branden Robinson <gbranden>
Group administrator
Tue 16 Mar 2021 09:14:45 PM UTC, comment #2: 
Dave <barx>
Group Member
Mon 15 Mar 2021 07:05:29 PM UTC, comment #1: 

This problem was later (re)discovered independently and posted to the email list: http://lists.gnu.org/archive/html/groff/2021-02/msg00075.html

Downthread, Tadziu posted a patch (https://lists.gnu.org/archive/html/groff/2021-03/msg00009.html), which I've attached here.  I'm not an -mm user and have done no testing of it beyond verifying that it fixes the problem in the test case posted here and the one posted on the list.

(file #51071)

Dave <barx>
Group Member
Thu 10 Oct 2019 05:37:16 PM UTC, original submission:  

Sample:
=======
.AU "John SMITH"
.AT "Director"
.MT 5
.P
sentence
.FC Sincerely,
.SG
==== groff output (via nroff)
                                                   October 10, 2019



       sentence

                                     Sincerely,



       ‐‐                            John SMITH
==== DWB output (via nroff)
                                                    October 10, 2019


       sentence

                                     Sincerely,



                                     John SMITH
                                     Director
=====
Same issue with groff pdf comparison.

Summary: Title does not appear in signature and extraneous "--".

groff test on Ubuntu 18.05, DWB on Solaris 10.





Ken Mandelberg <kmand>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by barx (Updated the item)
  • -email is unavailable- added by kmand (Submitted the item)
  • -email is unavailable- added by kmand
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-22 gbranden Item GroupNone Feature change
    2021-05-30 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.23.0
    2021-05-30 gbranden StatusNone In Progress
        Assigned toNone gbranden
        Summary[PATCH] AT MM Macro Does Not Display in Signature (SG) [PATCH] [mm] author title (AT) does not display in signature (SG)
    2021-03-16 barx Attached File#51071 Removed
    2021-03-15 barx Attached File- Added 57034.patch, #51071
        SummaryAT MM Macro Does Not Display in Signature (SG) [PATCH] AT MM Macro Does Not Display in Signature (SG)
    2019-10-10 kmand Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code