bugGNU Octave - Bugs: bug #55671, [octave forge] (control) nfields2...

 
 

bug #55671: [octave forge] (control) nfields2 undefined (development branch)

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Fri 08 Feb 2019 12:25:37 AM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  GNU/Linux

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 11 Feb 2019 09:02:06 PM UTC, comment #5: 

Fixed on the control package development branch

http://hg.code.sf.net/p/octave/control/rev/549466e74db5

Mike Miller <mtmiller>
Project Administrator
Fri 08 Feb 2019 06:54:05 PM UTC, comment #4: 

Yes please push.

Doug Stewart <dastew>
Fri 08 Feb 2019 05:14:34 PM UTC, comment #3: 

I can also push a fix for bug #55672, let me know. Together these fixes let me build and use the control package with Octave 6 in development, I don't think there's a need for an immediate release unless you have other fixes you want to release now.

Mike Miller <mtmiller>
Project Administrator
Fri 08 Feb 2019 02:07:14 PM UTC, comment #2: 

Yes Mike please push this.

 I did not expect that packagers would use the non released control pkg.

 I have more changes to come but maybe we should make a release now , and then a major release 4 weeks from now.

Doug Stewart <dastew>
Fri 08 Feb 2019 12:48:11 AM UTC, comment #1: 

Attached a change that fixes this for me and cleans up leftover references to nfields2.

I can push this directly to the control repository if this looks acceptable.

(file #46208)

Mike Miller <mtmiller>
Project Administrator
Fri 08 Feb 2019 12:25:37 AM UTC, original submission:  

If a snapshot of the current development branch of the control package is installed in Octave (any version), the following error comes out when displaying any system

>> sys = tf (1, [1, 1])

Transfer function 'sys' from input 'u1' to output ...

        1
y1:  -----
      s + 1

error: 'nfields2' undefined near line 27 column 7
error: called from
    display at line 27 column 3
    display at line 50 column 3

The nfields2 DEFUN has been removed from the control package (http://hg.code.sf.net/p/octave/control/rev/1daba0a58556), but it is still called throughout the package.

I can work up a patch to clean up the leftover references, and delete the nfields2.cc source file that's no longer needed.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46208:  bug55671.patch added by mtmiller (5KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dastew (Posted a comment)
  • -email is unavailable- added by mtmiller
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-02-11 mtmiller StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2019-02-08 mtmiller Carbon-Copy- => Added dastew
    2019-02-08 mtmiller Carbon-CopyRemoved 80942 => -
    2019-02-08 mtmiller Attached File- => Added bug55671.patch, #46208
        StatusNone => Patch Submitted

    Back to the top


    Powered by Savane 3.5